Bug 1693746
| Summary: | [RFE] Add new throttling option to the UI for "Maximum concurrent migrations per provider" | ||
|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | Satoe Imaishi <simaishi> |
| Component: | V2V | Assignee: | Fabien Dupont <fdupont> |
| Status: | CLOSED ERRATA | QA Contact: | Yadnyawalk Tale <ytale> |
| Severity: | medium | Docs Contact: | Red Hat CloudForms Documentation <cloudforms-docs> |
| Priority: | high | ||
| Version: | 5.10.2 | CC: | bthurber, mturley |
| Target Milestone: | GA | Keywords: | ZStream |
| Target Release: | 5.10.3 | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
| Fixed In Version: | 5.10.3.2 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | 1688951 | Environment: | |
| Last Closed: | 2019-04-23 07:46:25 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | V2V | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1688951 | ||
| Bug Blocks: | |||
|
Comment 2
CFME Bot
2019-04-01 14:28:31 UTC
New commits detected on ManageIQ/manageiq-v2v/hammer: https://github.com/ManageIQ/manageiq-v2v/commit/fde5b645e7c8327c616e0588f0a0d3825b4b6161 commit fde5b645e7c8327c616e0588f0a0d3825b4b6161 Author: Mike Turley <mike.turley.umass.edu> AuthorDate: Wed Mar 6 13:38:17 2019 -0500 Commit: Mike Turley <mike.turley.umass.edu> CommitDate: Wed Mar 6 13:38:17 2019 -0500 Merge pull request #892 from mzazrivec/rename_concurrent_migrations Rename Concurrent Migrations to Migration Throttling (cherry picked from commit 3f58aea9ecab13455e8c1d3c83424ea7198d0d53) https://bugzilla.redhat.com/show_bug.cgi?id=1693746 app/javascript/react/screens/App/Settings/Settings.js | 4 +- app/javascript/react/screens/App/Settings/__tests__/__snapshots__/Settings.test.js.snap | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) https://github.com/ManageIQ/manageiq-v2v/commit/9b2a950b3a2dbdb7a7bc44a5a2c7e38dbd004d43 commit 9b2a950b3a2dbdb7a7bc44a5a2c7e38dbd004d43 Author: Mike Turley <mike.turley.umass.edu> AuthorDate: Tue Mar 12 17:18:12 2019 -0400 Commit: Mike Turley <mike.turley.umass.edu> CommitDate: Tue Mar 12 17:18:12 2019 -0400 Merge pull request #897 from mzazrivec/add_new_options_for_migration_throttling Add new options for migration throttling (cherry picked from commit 5cee58ddbbbbe7e322363309a576d5729d58964b) https://bugzilla.redhat.com/show_bug.cgi?id=1693746 app/javascript/react/screens/App/Settings/Settings.scss | 5 + app/javascript/react/screens/App/Settings/helpers.js | 14 +- app/javascript/react/screens/App/Settings/screens/GeneralSettings/GeneralSettings.js | 104 +- app/javascript/react/screens/App/Settings/screens/GeneralSettings/index.js | 6 +- app/javascript/react/screens/App/common/forms/TextInputWithCheckbox.js | 71 + 5 files changed, 188 insertions(+), 12 deletions(-) https://github.com/ManageIQ/manageiq-v2v/commit/396d010a7826f42ed338b288dedb8291cf312edc commit 396d010a7826f42ed338b288dedb8291cf312edc Author: Mike Turley <mike.turley.umass.edu> AuthorDate: Tue Mar 12 17:47:31 2019 -0400 Commit: Mike Turley <mike.turley.umass.edu> CommitDate: Tue Mar 12 17:47:31 2019 -0400 Merge pull request #905 from mturley/fix-bad-snapshots Fix tests we missed in PR #897 (cherry picked from commit d462568426622038f4835a68f8e02f9ed1b70067) https://bugzilla.redhat.com/show_bug.cgi?id=1693746 app/javascript/react/screens/App/Settings/__tests__/__snapshots__/SettingsActions.test.js.snap | 2 + app/javascript/react/screens/App/Settings/__tests__/__snapshots__/SettingsReducer.test.js.snap | 2 + app/javascript/react/screens/App/Settings/screens/GeneralSettings/__tests__/__snapshots__/GeneralSettings.test.js.snap | 87 +- app/javascript/react/screens/App/Settings/settings.fixures.js | 6 +- 4 files changed, 88 insertions(+), 9 deletions(-) As discovered in the email thread with the subject "[BZ1693746] Can you confirm if changes only suppose to work for UI and not backend", we will need to backport this PR for this feature to work: https://github.com/ManageIQ/manageiq/pull/18539. YTale was also having issues with the max_concurrent_tasks_per_host setting, which predates this change and should not have stopped working. We may need a separate BZ to track that. New commit detected on ManageIQ/manageiq/hammer: https://github.com/ManageIQ/manageiq/commit/59d5d163e7e945518d0aef81734f7574d48fe1c9 commit 59d5d163e7e945518d0aef81734f7574d48fe1c9 Author: Adam Grare <agrare> AuthorDate: Mon Mar 11 09:25:34 2019 -0400 Commit: Adam Grare <agrare> CommitDate: Mon Mar 11 09:25:34 2019 -0400 Merge pull request #18539 from fdupont-redhat/v2v_use_settings_for_max_concurrent_tasks_per_ems [V2V] Throttler - Replace class constant with global setting (cherry picked from commit 5b6e5c56e76e3d928846a3f4078c84dcf1804bc5) https://bugzilla.redhat.com/show_bug.cgi?id=1693746 lib/infra_conversion_throttler.rb | 4 +- 1 file changed, 1 insertion(+), 3 deletions(-) Verified! UI and backend working with fix for max per provider, host still having issue and we are tacking that in https://bugzilla.redhat.com/show_bug.cgi?id=1698761. Checked on: 5.10.3.2.20190410215422_59d5d16 Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2019:0796 |