Bug 169527
| Summary: | wrong allocation size in tmp filename allocations | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Wojciech Milek <w.milek> | ||||
| Component: | dos2unix | Assignee: | Tim Waugh <twaugh> | ||||
| Status: | CLOSED DUPLICATE | QA Contact: | Ben Levenson <benl> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | 3 | ||||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2005-09-29 12:46:31 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
Created attachment 119414 [details]
Patch for this problem
This patch corrects wrong maloc call.
|
From Bugzilla Helper: User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.12) Gecko/20050915 Firefox/1.0.7 Description of problem: I noticed that durring changing many files using dos2unix tools some files are not converted with message: dos2unix: problems renaming './stcfg/cmd5528/d2utmpTBxaZb ' to './stcfg/cmd5528/reg5528.h' output file remains in './stcfg/cmd5528/d2utmpTBxaZb' dos2unix: problems converting file ./stcfg/cmd5528/reg5528.h Temporary filename created by dos2unix contains some additional spaces or white chars. This problem is caused by wrong allocation size and if size of temporary filename string % 4 == 0 end of this string is overwriten by next allocation :-) Version-Release number of selected component (if applicable): dos2unix-3.1 How reproducible: Sometimes Steps to Reproduce: 1. find . -name *.c - exec {} \; 2. 3. Actual Results: dos2unix: problems renaming './stcfg/cmd5528/d2utmpTBxaZb' to './stcfg/cmd5528/reg5528.h' output file remains in './stcfg/cmd5528/d2utmpTBxaZb' dos2unix: problems converting file ./stcfg/cmd5528/reg5528.h Expected Results: no such messages Additional info: