Bug 1695847

Summary: conversion host conversion state failure is potentially misleading
Product: Red Hat CloudForms Management Engine Reporter: Daniel Berger <dberger>
Component: V2VAssignee: Fabien Dupont <fdupont>
Status: CLOSED CURRENTRELEASE QA Contact: Yadnyawalk Tale <ytale>
Severity: high Docs Contact: Red Hat CloudForms Documentation <cloudforms-docs>
Priority: high    
Version: 5.10.2CC: bthurber, ytale
Target Milestone: GAKeywords: TestOnly, ZStream
Target Release: 5.11.0   
Hardware: Unspecified   
OS: Unspecified   
URL: https://github.com/ManageIQ/manageiq/pull/18258
Whiteboard: v2v
Fixed In Version: 5.11.0.1 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1702055 (view as bug list) Environment:
Last Closed: 2019-12-13 15:08:50 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: V2V Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1622728, 1702055    

Description Daniel Berger 2019-04-03 19:28:52 UTC 
It's possible that we could retrieve a conversion state file successfully, but the contents could be invalid. However, in such a situation the error message is misleading and makes it look like a connection failure.

To replicate, call the ConversionHost#get_conversion_state and have it retrieve an invalid json file.

The current result is that the error message will say "Could not get state file...".

The expected result is "Could not parse conversion state data...".
Comment 2 Fabien Dupont 2019-04-03 21:20:17 UTC 
https://github.com/ManageIQ/manageiq/pull/18258
Comment 4 Yadnyawalk Tale 2019-06-14 12:57:43 UTC 
Fixed! Verified on: 5.11.0.8.20190611155126_01e077e