Bug 1695847 - conversion host conversion state failure is potentially misleading
Summary: conversion host conversion state failure is potentially misleading
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: V2V
Version: 5.10.2
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: GA
: 5.11.0
Assignee: Fabien Dupont
QA Contact: Yadnyawalk Tale
Red Hat CloudForms Documentation
URL: https://github.com/ManageIQ/manageiq/...
Whiteboard: v2v
Depends On:
Blocks: 1622728 1702055
TreeView+ depends on / blocked
 
Reported: 2019-04-03 19:28 UTC by Daniel Berger
Modified: 2019-12-13 15:08 UTC (History)
2 users (show)

Fixed In Version: 5.11.0.1
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1702055 (view as bug list)
Environment:
Last Closed: 2019-12-13 15:08:50 UTC
Category: ---
Cloudforms Team: V2V
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Daniel Berger 2019-04-03 19:28:52 UTC
It's possible that we could retrieve a conversion state file successfully, but the contents could be invalid. However, in such a situation the error message is misleading and makes it look like a connection failure.

To replicate, call the ConversionHost#get_conversion_state and have it retrieve an invalid json file.

The current result is that the error message will say "Could not get state file...".

The expected result is "Could not parse conversion state data...".

Comment 2 Fabien Dupont 2019-04-03 21:20:17 UTC
https://github.com/ManageIQ/manageiq/pull/18258

Comment 4 Yadnyawalk Tale 2019-06-14 12:57:43 UTC
Fixed! Verified on: 5.11.0.8.20190611155126_01e077e


Note You need to log in before you can comment on or make changes to this bug.