Bug 1696111

Summary: RHV could not detect Guest Agent when create snapshot for the running guest which installed qemu-guest-agent
Product: [oVirt] ovirt-engine Reporter: liuzi <zili>
Component: BLL.VirtAssignee: Tomasz Barański <tbaransk>
Status: CLOSED CURRENTRELEASE QA Contact: Beni Pelled <bpelled>
Severity: high Docs Contact:
Priority: high    
Version: 4.3.0CC: bugs, hunter86_bg, juzhou, lsurette, mavital, michal.skrivanek, mkenneth, mxie, mzhan, rbarry, rjones, srevivo, tgolembi, tzheng, xiaodwan
Target Milestone: ovirt-4.4.0Keywords: ZStream
Target Release: ---Flags: pm-rhel: ovirt-4.4+
rbarry: devel_ack+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of:
: 1723582 (view as bug list) Environment:
Last Closed: 2020-05-20 20:00:00 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Virt RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1723582    
Attachments:
Description Flags
create snapshot
none
snapshot-applications none

Description liuzi 2019-04-04 07:43:57 UTC 
Created attachment 1551701 [details]
create snapshot

Description:
RHV could not detect Guest Agent when create snapshot for the running guest which installed qemu-guest-agent

Background:
Virt-v2v will install qemu-guest-agent in linux guests during converting guests to RHV,pls refer to https://bugzilla.redhat.com/show_bug.cgi?id=1619665#c4

How reproducible:
100%

Version:
qemu-kvm-rhev-2.12.0-25.el7.x86_64
libvirt-4.5.0-11.el7.x86_64
libguestfs-1.40.2-2.el7.x86_64
python-ovirt-engine-sdk4-4.3.1-1.el7ev.x86_64

Steps:
1.Prepare a guest has correctly installed qume-guest-agent and make sure the service is running normally.
I have prepared a rhel7.6 guest on rhv4.3
# rpm -q qemu-guest-agent
qemu-guest-agent-2.12.0-2.el7.x86_64

# systemctl status qemu-guest-agent
● qemu-guest-agent.service - QEMU Guest Agent
   Loaded: loaded (/usr/lib/systemd/system/qemu-guest-agent.service; enabled; vendor preset: enabled)
   Active: active (running) since Tue 2019-04-02 06:15:25 EDT; 1min 17s ago
 Main PID: 3095 (qemu-ga)
    Tasks: 1
   CGroup: /system.slice/qemu-guest-agent.service
           └─3095 /usr/bin/qemu-ga --method=virtio-serial --path=/dev/virtio-...

Apr 02 06:15:25 localhost.localdomain systemd[1]: Started QEMU Guest Agent.

2.Boot the guest and create snapshot for the guest on RHV GUI
Result: RHV will show warning info :Could not detect Guest Agent on the VM. Note that without a Guest Agent the data on the created snapshot may be inconsistent. Pls refer to screenshot named create-snapshot.
But the snapshot can be created normally and the snapshot can detect qemu-guest-agent,pls refer to screenshot named snapshot-applications

Actual results:
As above

Expected results:
RHV can detect Guest Agent when create snapshot for the running guest which installed qemu-guest-agent

Additional info:
1.Can be reproduced on rhv4.2
2.Cannot be reproduced when the guest installed ovirt-guest-agent.
Comment 1 liuzi 2019-04-04 07:45:38 UTC 
Created attachment 1551702 [details]
snapshot-applications
Comment 2 Tomáš Golembiovský 2019-04-04 08:54:02 UTC 
I assumed this was fixed as part of bug 1615830. Anyway, it should be possible to do that now.

The snapshot feature only depends on QEMU-GA so the check should be changed in engine. The warning message could be more specific about which agent it needs too.
Comment 3 Michal Skrivanek 2019-04-05 04:43:01 UTC 
Ah, the bug 1615830 shouldn’t have been closed, it wasn’t finished!
Comment 4 Strahil Nikolov 2019-05-21 09:11:56 UTC 
I experience the same issue on oVirt 4.3.4 RC1 - the warning is showed when using qemu-guest-agent , but is not shown with ovirt-guest-agent.
Tested on RHEL 8 VM and openSUSE Leap 15.0 .
Comment 5 Tomáš Golembiovský 2019-05-21 10:12:37 UTC 
I am raising the priority because this is not just about a warning in UI. What is more important is that the fs-freeze is not performed. This is likely to result in corrupted snapshots.
Comment 6 Michal Skrivanek 2019-06-24 07:32:18 UTC 
(In reply to liuzi from comment #0)
please don't open downstream RHV bugs when the issue is not RHV-specific
Comment 8 Strahil Nikolov 2019-07-05 15:49:56 UTC 
I don't observe the issue any longer. I'm running  ovirt 4.3.5.3-1.el7 qemu-guest-agent (RHEL 8 & openSUSE 15.1).
Comment 9 Beni Pelled 2020-03-22 13:58:51 UTC 
Verified on:
- RHV 4.3.9.4-11.el7
- libvirt-4.5.0-33.el7.x86_64 (host)
- vdsm-4.30.43-1.el7ev.x86_64 (host)


Verification steps:
1. Create a VM with Red Hat Enterprise Linux Server 7.7 (Maipo)
2. Make sure the qemu-guest-agent is up and running
3. Create a snapshot (with memory)


Result:
- The snapshot is successfully created wit no warning message or any other issue.
Comment 10 Sandro Bonazzola 2020-05-20 20:00:00 UTC 
This bugzilla is included in oVirt 4.4.0 release, published on May 20th 2020.

Since the problem described in this bug report should be
resolved in oVirt 4.4.0 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.