Bug 1696168
| Summary: | should replace all "clusteringress" with "ingresscontroller" to avoid confusing | ||
|---|---|---|---|
| Product: | OpenShift Container Platform | Reporter: | Hongan Li <hongli> |
| Component: | Networking | Assignee: | Dan Mace <dmace> |
| Networking sub component: | router | QA Contact: | Hongan Li <hongli> |
| Status: | CLOSED ERRATA | Docs Contact: | |
| Severity: | medium | ||
| Priority: | low | CC: | aos-bugs, dmace |
| Version: | 4.1.0 | ||
| Target Milestone: | --- | ||
| Target Release: | 4.1.0 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: |
Cause: ClusterIngress API is replaced to IngressController API that has some more improvements.
Consequence: Rest of the cluster-ingress-operator code is still referencing the old "clusteringress" name.
Fix: Rename clusteringress to the updated API name where ever is appropriate.
Result: Less confusion and easy to follow the code.
|
Story Points: | --- |
| Clone Of: | Environment: | ||
| Last Closed: | 2019-06-04 10:47:03 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
verified with 4.0.0-0.ci-2019-04-16-221411 and issue has been fixed. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2019:0758 |
Description of problem: To avoid confusing and keep consistent, we should replace all "clusteringress" with "ingresscontroller", especially those information exposed to user. Version-Release number of selected component (if applicable): 4.0.0-0.nightly-2019-04-03-202419 How reproducible: 100% Steps to Reproduce: 1. cd cluster-ingress-operator/ 2. grep -r -i "clusteringress" ./* 3. Actual results: --- ./pkg/manifests/manifests.go: OwningClusterIngressLabel = "ingress.openshift.io/clusteringress" ./pkg/operator/controller/controller_router_deployment.go: return nil, fmt.Errorf("clusteringress %q has invalid spec.routeSelector: %v", ci.Name, err) ./pkg/operator/controller/controller.go: return fmt.Errorf("failed to remove finalizer from clusteringress %s: %v", ingress.Name, err) ./pkg/operator/controller/controller_dns.go: log.Info("ensured DNS record for clusteringress", "namespace", ci.Namespace, "name", ci.Name, "record", record) Expected results: replace "clusteringress" with "ingresscontroller" Additional info: