Bug 1696795

Summary: TODO comment in the main.yml file
Product: [oVirt] ovirt-engine-metrics Reporter: Ivana Saranova <isaranov>
Component: GenericAssignee: Shirly Radco <sradco>
Status: CLOSED CURRENTRELEASE QA Contact: Ivana Saranova <isaranov>
Severity: medium Docs Contact:
Priority: medium    
Version: 1.2.1.3CC: bugs, lleistne
Target Milestone: ovirt-4.3.4Flags: sbonazzo: ovirt-4.3?
lleistne: testing_ack+
Target Release: 1.3.1   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: ovirt-engine-metrics-1.3.1 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-06-11 06:25:39 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Metrics RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 1710361    

Description Ivana Saranova 2019-04-05 16:31:54 UTC 
Description of problem:
On the line 58 in the /usr/share/ansible/roles/oVirt.metrics/roles/oVirt.origin-on-ovirt/tasks/main.yml there is a TODO comment that probably shouldn't be there.


Version-Release number of selected component (if applicable):
ovirt-engine-4.3.3.1-0.1.el7.noarch
ovirt-engine-metrics-1.2.1.3-1.el7ev.noarch

How reproducible:
Always

Steps to Reproduce:
1. Check /usr/share/ansible/roles/oVirt.metrics/roles/oVirt.origin-on-ovirt/tasks/main.yml
2.
3.

Actual results:
...
# TODO replace with ansible module
...

Expected results:
No TODO line in the official package

Additional info:
Comment 1 Ivana Saranova 2019-05-29 10:44:30 UTC 
Steps: 
1. Check /usr/share/ansible/roles/oVirt.metrics/roles/oVirt.origin-on-ovirt/tasks/main.yml

Results:
No TODO line in the official package

Verified in:
ovirt-engine-4.3.4.1-0.1.el7.noarch
ovirt-engine-metrics-1.3.1-1.el7ev.noarch
Comment 2 Sandro Bonazzola 2019-06-11 06:25:39 UTC 
This bugzilla is included in oVirt 4.3.4 release, published on June 11th 2019.

Since the problem described in this bug report should be
resolved in oVirt 4.3.4 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.