Bug 1696795 - TODO comment in the main.yml file
Summary: TODO comment in the main.yml file
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine-metrics
Classification: oVirt
Component: Generic
Version: 1.2.1.3
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ovirt-4.3.4
: 1.3.1
Assignee: Shirly Radco
QA Contact: Ivana Saranova
URL:
Whiteboard:
Depends On:
Blocks: 1710361
TreeView+ depends on / blocked
 
Reported: 2019-04-05 16:31 UTC by Ivana Saranova
Modified: 2019-06-11 06:25 UTC (History)
2 users (show)

Fixed In Version: ovirt-engine-metrics-1.3.1
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-06-11 06:25:39 UTC
oVirt Team: Metrics
Embargoed:
sbonazzo: ovirt-4.3?
lleistne: testing_ack+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 99369 0 master MERGED Remove comment for "Get bastion ssh public key" task 2019-04-14 08:24:44 UTC
oVirt gerrit 99765 0 ovirt-engine-metrics-4.2 MERGED Remove comment for "Get bastion ssh public key" task 2019-05-05 12:18:03 UTC

Description Ivana Saranova 2019-04-05 16:31:54 UTC
Description of problem:
On the line 58 in the /usr/share/ansible/roles/oVirt.metrics/roles/oVirt.origin-on-ovirt/tasks/main.yml there is a TODO comment that probably shouldn't be there.


Version-Release number of selected component (if applicable):
ovirt-engine-4.3.3.1-0.1.el7.noarch
ovirt-engine-metrics-1.2.1.3-1.el7ev.noarch

How reproducible:
Always

Steps to Reproduce:
1. Check /usr/share/ansible/roles/oVirt.metrics/roles/oVirt.origin-on-ovirt/tasks/main.yml
2.
3.

Actual results:
...
# TODO replace with ansible module
...

Expected results:
No TODO line in the official package

Additional info:

Comment 1 Ivana Saranova 2019-05-29 10:44:30 UTC
Steps: 
1. Check /usr/share/ansible/roles/oVirt.metrics/roles/oVirt.origin-on-ovirt/tasks/main.yml

Results:
No TODO line in the official package

Verified in:
ovirt-engine-4.3.4.1-0.1.el7.noarch
ovirt-engine-metrics-1.3.1-1.el7ev.noarch

Comment 2 Sandro Bonazzola 2019-06-11 06:25:39 UTC
This bugzilla is included in oVirt 4.3.4 release, published on June 11th 2019.

Since the problem described in this bug report should be
resolved in oVirt 4.3.4 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.