Bug 1699585 (rust-vte)

Summary: Review Request: rust-vte - Parser for implementing terminal emulators
Product: [Fedora] Fedora Reporter: Robert-André Mauchin 🐧 <eclipseo>
Component: Package ReviewAssignee: Zbigniew Jędrzejewski-Szmek <zbyszek>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: igor.raits, package-review, zbyszek
Target Milestone: ---Flags: zbyszek: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-04-24 06:35:50 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1699586    
Bug Blocks: 1699645    

Description Robert-André Mauchin 🐧 2019-04-13 22:24:48 UTC
Spec URL: https://eclipseo.fedorapeople.org/for-review/rust-vte.spec
SRPM URL: https://eclipseo.fedorapeople.org/for-review/rust-vte-0.3.3-1.fc31.src.rpm

Description:
Parser for implementing virtual terminal emulators in Rust.  The parser is implemented according to Paul Williams' ANSI parser state machine. The state machine doesn't assign meaning to the parsed data and is thus not itself sufficient for writing a terminal emulator. Instead, it is expected that an implementation of the Perform trait which does something useful with the parsed data. The Parser handles the book keeping, and the Perform gets to simply handle actions.

Fedora Account System Username: eclipseo

Comment 1 Robert-André Mauchin 🐧 2019-04-13 22:28:14 UTC
Successful COPR build: https://copr.fedorainfracloud.org/coprs/eclipseo/rusttests/build/883114/

Comment 2 Zbigniew Jędrzejewski-Szmek 2019-04-22 21:47:42 UTC
This is a mostly-automatically generated crate package, so just a quick check:
+ package name is OK
+ license is acceptable for Fedora (ASL2.0 or MIT)
+ license is specified correctly
+ builds and installs OK
+ latest version

Package is APPROVED.

Comment 3 Igor Raits 2019-04-24 06:10:12 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-vte