Bug 1699645 (rust-skim) - Review Request: rust-skim - Fuzzy Finder in Rust
Summary: Review Request: rust-skim - Fuzzy Finder in Rust
Keywords:
Status: CLOSED RAWHIDE
Alias: rust-skim
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Zbigniew Jędrzejewski-Szmek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: rust-tuikit rust-vte rust-fuzzy-matcher rust-timer
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-04-14 15:46 UTC by Robert-André Mauchin 🐧
Modified: 2019-04-24 07:34 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2019-04-24 07:34:37 UTC
Type: ---
Embargoed:
zbyszek: fedora-review+

Attachments (Terms of Use)

Description Robert-André Mauchin 🐧 2019-04-14 15:46:26 UTC 
Spec URL: https://eclipseo.fedorapeople.org/for-review/rust-skim.spec
SRPM URL: https://eclipseo.fedorapeople.org/for-review/rust-skim-0.6.6-1.fc31.src.rpm

Description:
Fuzzy Finder in Rust.

Fedora Account System Username: eclipseo
Comment 1 Robert-André Mauchin 🐧 2019-04-14 15:50:02 UTC 
Successful COPR build: https://copr.fedorainfracloud.org/coprs/eclipseo/rusttests/build/883262/
Comment 2 Zbigniew Jędrzejewski-Szmek 2019-04-23 08:53:53 UTC 
Looks like a really nice tool.

%description should be extended: find what in what? What does it mean fuzzy?

This is a mostly-automatically generated crate package, so just a quick check:
+ package name is OK
+ license is acceptable for Fedora (MIT)
+ license is specified correctly
+ patches have links to upstream PRs
+ builds and installs OK
+ seems to work as advertised
+ latest version

There's a number of executables with similar names, but 'sk' itself is unused.

Package is APPROVED.
Comment 3 Igor Raits 2019-04-24 06:13:36 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-skim
Note You need to log in before you can comment on or make changes to this bug.