Bug 1699645 (rust-skim)

Summary:	Review Request: rust-skim - Fuzzy Finder in Rust
Product:	[Fedora] Fedora	Reporter:	Robert-André Mauchin 🐧 <eclipseo>
Component:	Package Review	Assignee:	Zbigniew Jędrzejewski-Szmek <zbyszek>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	igor.raits, me, package-review, zbyszek
Target Milestone:	---	Flags:	zbyszek: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-04-24 07:34:37 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1699581, 1699585, 1699591, 1699593
Bug Blocks:

Description Robert-André Mauchin 🐧 2019-04-14 15:46:26 UTC

Spec URL: https://eclipseo.fedorapeople.org/for-review/rust-skim.spec
SRPM URL: https://eclipseo.fedorapeople.org/for-review/rust-skim-0.6.6-1.fc31.src.rpm

Description:
Fuzzy Finder in Rust.

Fedora Account System Username: eclipseo

Comment 1 Robert-André Mauchin 🐧 2019-04-14 15:50:02 UTC

Successful COPR build: https://copr.fedorainfracloud.org/coprs/eclipseo/rusttests/build/883262/

Comment 2 Zbigniew Jędrzejewski-Szmek 2019-04-23 08:53:53 UTC

Looks like a really nice tool.

%description should be extended: find what in what? What does it mean fuzzy?

This is a mostly-automatically generated crate package, so just a quick check:
+ package name is OK
+ license is acceptable for Fedora (MIT)
+ license is specified correctly
+ patches have links to upstream PRs
+ builds and installs OK
+ seems to work as advertised
+ latest version

There's a number of executables with similar names, but 'sk' itself is unused.

Package is APPROVED.

Comment 3 Igor Raits 2019-04-24 06:13:36 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-skim