Bug 1702313 (rust-tokio-async-await)

Summary:	Review Request: rust-tokio-async-await - Experimental async/await support for Tokio
Product:	[Fedora] Fedora	Reporter:	Igor Raits <igor.raits>
Component:	Package Review	Assignee:	Robert-André Mauchin 🐧 <eclipseo>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	eclipseo, package-review
Target Milestone:	---	Flags:	eclipseo: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-04-28 13:51:44 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Igor Raits 2019-04-23 13:29:06 UTC

Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-tokio-async-await.spec
SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-tokio-async-await-0.1.7-1.fc31.src.rpm
Description:
Experimental async/await support for Tokio
Fedora Account System Username: ignatenkobrain

Comment 1 Robert-André Mauchin 🐧 2019-04-24 22:55:46 UTC

 -  Add a dot at the end of the description:

%global _description \
Experimental async/await support for Tokio.

 - You must install the LICENSE file with %license in %files and you should install the README.md file with %doc:

%files          devel
%license LICENSE
%doc README.md
%{cargo_registry}/%{crate}-%{version}/


 - License ok
 - Latest version packaged
 - Builds in mock
 - No rpmlint errors


Package is not installable:

DEBUG util.py:556:  Last metadata expiration check: 0:00:01 ago on Thu Apr 25 00:44:06 2019.
DEBUG util.py:554:  BUILDSTDERR: Error: 
DEBUG util.py:554:  BUILDSTDERR:  Problem: conflicting requests
DEBUG util.py:554:  BUILDSTDERR:   - nothing provides (crate(futures/nightly) >= 0.1.23 with crate(futures/nightly) < 0.2.0) needed by rust-tokio-async-await+async-await-preview-devel-0.1.7-1.fc31.noarch

Comment 2 Igor Raits 2019-04-24 23:01:11 UTC

New Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-tokio-async-await.spec
New SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-tokio-async-await-0.1.7-1.fc31.src.rpm

Comment 3 Igor Raits 2019-04-24 23:02:23 UTC

Since rust packages are not supposed to be shipped to users, they don't have to be all installable. I've fixed others.

Comment 4 Igor Raits 2019-04-24 23:02:45 UTC

Also, I'll add "nightly" feature into futures at some point.

Comment 5 Robert-André Mauchin 🐧 2019-04-24 23:21:58 UTC

(In reply to Igor Gnatenko from comment #3)
> Since rust packages are not supposed to be shipped to users, they don't have
> to be all installable. I've fixed others.

Even to build a module you need it to be installable, no? Or you have worked on your idea to have all packages sources "simply copied" instead of building?


Package approved.

Comment 6 Igor Raits 2019-04-28 13:44:13 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-tokio-async-await