Bug 1702313 (rust-tokio-async-await) - Review Request: rust-tokio-async-await - Experimental async/await support for Tokio
Summary: Review Request: rust-tokio-async-await - Experimental async/await support for...
Keywords:
Status: CLOSED RAWHIDE
Alias: rust-tokio-async-await
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-04-23 13:29 UTC by Igor Raits
Modified: 2019-04-28 13:51 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2019-04-28 13:51:44 UTC
Type: ---
Embargoed:
eclipseo: fedora-review+


Attachments (Terms of Use)

Description Igor Raits 2019-04-23 13:29:06 UTC
Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-tokio-async-await.spec
SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-tokio-async-await-0.1.7-1.fc31.src.rpm
Description:
Experimental async/await support for Tokio
Fedora Account System Username: ignatenkobrain

Comment 1 Robert-André Mauchin 🐧 2019-04-24 22:55:46 UTC
 -  Add a dot at the end of the description:

%global _description \
Experimental async/await support for Tokio.

 - You must install the LICENSE file with %license in %files and you should install the README.md file with %doc:

%files          devel
%license LICENSE
%doc README.md
%{cargo_registry}/%{crate}-%{version}/


 - License ok
 - Latest version packaged
 - Builds in mock
 - No rpmlint errors


Package is not installable:

DEBUG util.py:556:  Last metadata expiration check: 0:00:01 ago on Thu Apr 25 00:44:06 2019.
DEBUG util.py:554:  BUILDSTDERR: Error: 
DEBUG util.py:554:  BUILDSTDERR:  Problem: conflicting requests
DEBUG util.py:554:  BUILDSTDERR:   - nothing provides (crate(futures/nightly) >= 0.1.23 with crate(futures/nightly) < 0.2.0) needed by rust-tokio-async-await+async-await-preview-devel-0.1.7-1.fc31.noarch

Comment 3 Igor Raits 2019-04-24 23:02:23 UTC
Since rust packages are not supposed to be shipped to users, they don't have to be all installable. I've fixed others.

Comment 4 Igor Raits 2019-04-24 23:02:45 UTC
Also, I'll add "nightly" feature into futures at some point.

Comment 5 Robert-André Mauchin 🐧 2019-04-24 23:21:58 UTC
(In reply to Igor Gnatenko from comment #3)
> Since rust packages are not supposed to be shipped to users, they don't have
> to be all installable. I've fixed others.

Even to build a module you need it to be installable, no? Or you have worked on your idea to have all packages sources "simply copied" instead of building?


Package approved.

Comment 6 Igor Raits 2019-04-28 13:44:13 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-tokio-async-await


Note You need to log in before you can comment on or make changes to this bug.