Bug 1702884

+++ This bug was initially created as a clone of Bug #1043311 +++

Description of problem:

when pushing files to github with git, ksshaskpass is brought up by default to ask for username and password. It does this with two successive dialogs. One for to obtain the git repo username, and another to obtain the git repo password. 

When it asks for username, (the fist dialog) the dialog text doesn't clearly indicate it is asking for github username, but rather a password. User can mistakenly enter password, which then may be sent over over public DNS request as a path component to the repository.

Dialog is titled: ksshaskpass
Dialog has a key icon in it, suggesting secure input is being requested.
Dialog has a checkbox labeled "Remember Password"
Dialog appears when not using ssh, but SSL connection.
Dialog is split into two stages, rather than a single stage asking for username and password in the same place.

Version-Release number of selected component (if applicable):

Linux desktop.allanbowhill.org 3.11.10-200.fc19.x86_64 #1 SMP Mon Dec 2 20:28:03 UTC 2013 x86_64 x86_64 x86_64 GNU/Linux

How reproducible:

Steps to Reproduce:
1. Install git locally
2. Establish a git account and repo
3. Setup a checkin of new files, not using ssh-agent or special configs, but out of box usage.
4. Run 'git push origin master'

Actual results:

First dialog appears asking for username, but is not clear. If user enters password instead, password appears to be sent as the domain name:

'https://<password>@github.com'

Expected results:

'https://<username>@github.com'

Additional info:

--- Additional comment from Christian Schwarzgruber on 2015-02-10 14:37:49 UTC ---

Same here, it confuses me every time. Therefore, I have uninstalled the application until this gets fixed one day or another.

--- Additional comment from Jaroslav Reznik on 2015-03-03 15:19:46 UTC ---

This bug appears to have been reported against 'rawhide' during the Fedora 22 development cycle.
Changing version to '22'.

More information and reason for this action is here:
https://fedoraproject.org/wiki/Fedora_Program_Management/HouseKeeping/Fedora22

--- Additional comment from David Jones on 2016-03-10 20:31:16 UTC ---

This thread explains the reason for this issue, and offers a potential work-around.

http://git.661346.n2.nabble.com/Git-ksshaskpass-to-play-nice-with-https-and-kwallet-td6858195.html

--- Additional comment from Fedora End Of Life on 2016-07-19 10:47:36 UTC ---

Fedora 22 changed to end-of-life (EOL) status on 2016-07-19. Fedora 22 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.

--- Additional comment from Penelope Fudd on 2019-04-25 05:52:28 UTC ---

This is still happening in 2019 with Fedora 29.

Ksshaskpass still isn't fixed, 6 years after this was reported.

The first time I tried to do 'git push' to my very first Github repository, it asked for my username using a password field (with '*' masking), and the wording was confusing enough that I entered my password instead.  

Now it won't let me change the username, and instead prints "Password for 'https://<password>@github.com':"

I've searched all of my files and can't find the password string anywhere, I guess it's encrypted in KWallet?

Thanks