Bug 1702884 - ksshaskpass asks for username with password dialog, allowing mistaken pass to become part of URL
Summary: ksshaskpass asks for username with password dialog, allowing mistaken pass to...
Keywords:
Status: CLOSED EOL
Alias: None
Product: Fedora
Classification: Fedora
Component: ksshaskpass
Version: 29
Hardware: x86_64
OS: Linux
unspecified
high
Target Milestone: ---
Assignee: Aurelien Bompard
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-04-25 05:54 UTC by Penelope Fudd
Modified: 2022-07-06 15:00 UTC (History)
9 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1043311
Environment:
https://cgit.kde.org/ksshaskpass.git https://bugz.fedoraproject.org/ksshaskpass
Last Closed: 2019-11-27 22:09:04 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
KDE Software Compilation 343562 0 None None None 2019-04-26 14:11:43 UTC

Description Penelope Fudd 2019-04-25 05:54:23 UTC
+++ This bug was initially created as a clone of Bug #1043311 +++

Description of problem:

when pushing files to github with git, ksshaskpass is brought up by default to ask for username and password. It does this with two successive dialogs. One for to obtain the git repo username, and another to obtain the git repo password. 

When it asks for username, (the fist dialog) the dialog text doesn't clearly indicate it is asking for github username, but rather a password. User can mistakenly enter password, which then may be sent over over public DNS request as a path component to the repository.

Dialog is titled: ksshaskpass
Dialog has a key icon in it, suggesting secure input is being requested.
Dialog has a checkbox labeled "Remember Password"
Dialog appears when not using ssh, but SSL connection.
Dialog is split into two stages, rather than a single stage asking for username and password in the same place.

Version-Release number of selected component (if applicable):

Linux desktop.allanbowhill.org 3.11.10-200.fc19.x86_64 #1 SMP Mon Dec 2 20:28:03 UTC 2013 x86_64 x86_64 x86_64 GNU/Linux

How reproducible:

Steps to Reproduce:
1. Install git locally
2. Establish a git account and repo
3. Setup a checkin of new files, not using ssh-agent or special configs, but out of box usage.
4. Run 'git push origin master'

Actual results:

First dialog appears asking for username, but is not clear. If user enters password instead, password appears to be sent as the domain name:

'https://<password>@github.com'

Expected results:

'https://<username>@github.com'

Additional info:

--- Additional comment from Christian Schwarzgruber on 2015-02-10 14:37:49 UTC ---

Same here, it confuses me every time. Therefore, I have uninstalled the application until this gets fixed one day or another.

--- Additional comment from Jaroslav Reznik on 2015-03-03 15:19:46 UTC ---

This bug appears to have been reported against 'rawhide' during the Fedora 22 development cycle.
Changing version to '22'.

More information and reason for this action is here:
https://fedoraproject.org/wiki/Fedora_Program_Management/HouseKeeping/Fedora22

--- Additional comment from David Jones on 2016-03-10 20:31:16 UTC ---

This thread explains the reason for this issue, and offers a potential work-around.

http://git.661346.n2.nabble.com/Git-ksshaskpass-to-play-nice-with-https-and-kwallet-td6858195.html

--- Additional comment from Fedora End Of Life on 2016-07-19 10:47:36 UTC ---

Fedora 22 changed to end-of-life (EOL) status on 2016-07-19. Fedora 22 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.

--- Additional comment from Penelope Fudd on 2019-04-25 05:52:28 UTC ---

This is still happening in 2019 with Fedora 29.

Ksshaskpass still isn't fixed, 6 years after this was reported.

The first time I tried to do 'git push' to my very first Github repository, it asked for my username using a password field (with '*' masking), and the wording was confusing enough that I entered my password instead.  

Now it won't let me change the username, and instead prints "Password for 'https://<password>@github.com':"

I've searched all of my files and can't find the password string anywhere, I guess it's encrypted in KWallet?

Thanks

Comment 1 Penelope Fudd 2019-04-25 06:03:39 UTC
I saw bug 1676500 "ksshaskpass-5.15.4 is available", but the only changes made between ksshaskpass-5.14.5-1.fc29.x86_64 and the latest version are to the version number in the code.

Comment 2 Penelope Fudd 2019-04-25 09:29:23 UTC
Yes, that was it: run 'kwalletmanager5', go to the 'ksshaskpass' folder, and there will be one 'password' for 'https://github.com' containing the GitHub username (e.g. username), and another 'password' for 'https://username@yourdomain.com@github.com' containing the actual password.

I edited the contents of the first 'password' to replace my password with my username, deleted the second 'password', and everything worked right again.

The program still needs to be fixed, though.  :-)

Comment 3 Rex Dieter 2019-04-25 13:16:15 UTC
Ideally, please report this upstream to bugs.kde.org

We have little resources to implement fixes downstream without at least their (upstream) collaboaration, thanks.

Comment 4 Penelope Fudd 2019-04-26 08:03:07 UTC
It was already reported and confirmed, and I've added my two bits: https://bugs.kde.org/show_bug.cgi?id=343562

Comment 5 Rex Dieter 2019-04-26 14:11:44 UTC
Thanks.

Comment 6 Ben Cotton 2019-10-31 19:32:59 UTC
This message is a reminder that Fedora 29 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora 29 on 2019-11-26.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
Fedora 'version' of '29'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 29 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 7 Ben Cotton 2019-11-27 22:09:04 UTC
Fedora 29 changed to end-of-life (EOL) status on 2019-11-26. Fedora 29 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.

Comment 8 `{third: "Beedell", first: "Roke"}`{.JSON5} 2022-07-05 20:18:26 UTC
This remains problematic. Please reopen.

Comment 9 Rex Dieter 2022-07-06 15:00:23 UTC
This is already being tracked upstream, that's ideal

https://bugs.kde.org/show_bug.cgi?id=343562


Note You need to log in before you can comment on or make changes to this bug.