Bug 1705753
Summary: | Missing openapi CRD definitions for oc explain to work for sample operator CRD | |||
---|---|---|---|---|
Product: | OpenShift Container Platform | Reporter: | Ben Parees <bparees> | |
Component: | Templates | Assignee: | Gabe Montero <gmontero> | |
Status: | CLOSED ERRATA | QA Contact: | XiuJuan Wang <xiuwang> | |
Severity: | unspecified | Docs Contact: | ||
Priority: | unspecified | |||
Version: | 4.1.0 | CC: | adam.kaplan, aos-bugs, jokerman, maszulik, mmccomas, obulatov, wzheng | |
Target Milestone: | --- | |||
Target Release: | 4.2.0 | |||
Hardware: | Unspecified | |||
OS: | Unspecified | |||
Whiteboard: | ||||
Fixed In Version: | Doc Type: | Bug Fix | ||
Doc Text: |
Cause: The CRD for the samples operator config object (configs.samples.operator.openshift.io) did not have openAPIV3Schema validation defined
Consequence: `oc explain` was unable to provide useful information about the samples operator config object
Fix: necessary auto-generation code to construct the openAPIV3Schema validation was introduced into the cluster operator make process
Result: `oc explain` no works on the samples operator config object (configs.samples.operator.openshift.io)
|
Story Points: | --- | |
Clone Of: | 1705752 | |||
: | 1743376 (view as bug list) | Environment: | ||
Last Closed: | 2019-10-16 06:28:30 UTC | Type: | --- | |
Regression: | --- | Mount Type: | --- | |
Documentation: | --- | CRM: | ||
Verified Versions: | Category: | --- | ||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
Cloudforms Team: | --- | Target Upstream Version: | ||
Embargoed: | ||||
Bug Depends On: | 1705752, 1714775 | |||
Bug Blocks: | 1734402, 1743376 |
Description
Ben Parees
2019-05-02 21:15:33 UTC
Created this clone to address the samples-operator aspect of Maciej's comment above. so I see this targeted at 4.1.0, but the priority/severity are unspecified should I assume this has to get into 4.1.0 GA ? unless Maciej says otherwise, yes. You can ask him what the importance is since he originated them. @Maciej this is a bit of a riskier proposition, since adding library-go requires bumping k8s.io deps to 1.13. Can we address this as tech debt in 4.2 (with a potential z-stream update for 4.1)? fyi https://github.com/openshift/cluster-openshift-controller-manager-operator appears to implement the crd codegen defs and is glide based In addition to the 1.13 bump, samples operator is going to have to be added to openshift/api a la https://github.com/openshift/api/pull/183 in order for go run ./vendor/github.com/openshift/library-go/cmd/crd-schema-gen/main.go --domain openshift.io --apis-dir vendor/github.com/openshift/api --manifests-dir manifests/ to work. Without that update, I get Config.samples.operator.openshift.io no API type for found CRD manifests exit status 1 Paul just told me that Maciej says z-stream is fine sorted out with some Ben assistance the following to bypass openshift/api updates: go run ./vendor/github.com/openshift/library-go/cmd/crd-schema-gen/main.go --domain operator.openshift.io --apis-dir pkg/apis --manifests-dir manifests/ Yeah, that should work. The main gist is just the crd-schema-gen call. 4.1.x is perfect to land this. Thanks Maciej PR https://github.com/openshift/cluster-samples-operator/pull/144 is up for review and regression testing while we wait for 4.1.x to open up. *** Bug 1708600 has been marked as a duplicate of this bug. *** moving to 4.2.0, if you decide to backport it to 4.1.z create a clone. master branch / 4.2.0 PR has merged moving to ON_QA to await build Turns out 4.2 builds are not ready yet on the OSBS/brew side. I'm in contact with the ART to track when they become available. Moving to Modified After running `oc explain` with the changes from https://github.com/openshift/cluster-samples-operator/pull/144 I'm going to update some godoc and clean up a few things, enhance a few things. New PR coming Moving back to ASSIGNED until new PR comes up. Also, I think there is enough there though to re-enable the test in openshift/origin/test/extended/cli/explain.go PR https://github.com/openshift/cluster-samples-operator/pull/148 is up FYI ... run oc explain configs --api-version=samples.operator.openshift.io/v1 to see spec/status updates Also, https://github.com/openshift/origin/pull/22899 re-enables samples operator in the extended test Maciej referenced in the description PR has merged Check with 4.2.0-0.ci-2019-05-23-230227 The DESCRIPTION part is empty, and inconsistent space between apiVersion, metadata $ oc explain configs --api-version=samples.operator.openshift.io/v1 KIND: Config VERSION: samples.operator.openshift.io/v1 DESCRIPTION: <empty> FIELDS: apiVersion <string> APIVersion defines the versioned schema of this representation of an object. Servers should convert recognized schemas to the latest internal value, and may reject unrecognized values. More info: https://git.k8s.io/community/contributors/devel/api-conventions.md#resources kind <string> Kind is a string value representing the REST resource this object represents. Servers may infer this from the endpoint the client submits requests to. Cannot be updated. In CamelCase. More info: https://git.k8s.io/community/contributors/devel/api-conventions.md#types-kinds metadata <Object> Standard object's metadata. More info: https://git.k8s.io/community/contributors/devel/api-conventions.md#metadata spec <Object> Spec contains the desired configuration and state for the Samples Operator, controlling various behavior around the imagestreams and templates it creates/updates in the openshift namespace. status <Object> Status contains the actual configuration in effect, as well as various details that describe the state of the Samples Operator. Those are generic `oc explain` items, not anything to do with the changes around this bug. You'll see the same thing if you run `oc explain` against the other CRDs. That is what I saw when I tested this. Open a bug against the CLI component if you want those addressed. The spec/status you noted above is valid verification of this bug. Gabe, Thanks~ Move to verified as comment #20 Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2019:2922 |