Bug 1706787
| Summary: | Review Request: ansible-freeipa - Roles and playbooks to deploy FreeIPA servers, replicas and clients | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Thomas Woerner <twoerner> |
| Component: | Package Review | Assignee: | François Cami <contribs> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | contribs, fcami, package-review |
| Target Milestone: | --- | Flags: | contribs:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2019-05-09 14:34:31 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Thomas Woerner
2019-05-06 10:19:16 UTC
Taken. Expect a review with 24 hours. Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=34742464 rpmlint output (warnings are spurious): $ rpmlint ansible-freeipa.spec ansible-freeipa-0.1.1-1.fc30.noarch.rpm ansible-freeipa-0.1.1-1.fc30.src.rpm ansible-freeipa.noarch: W: spelling-error %description -l en_US gssapi -> sapping ansible-freeipa.src: W: spelling-error %description -l en_US gssapi -> sapping 2 packages and 1 specfiles checked; 0 errors, 2 warnings. MUST: * rpmlint [OK] * naming [OK] * spec file naming [OK] * Packaging Guidelines [OK] with no remark * license within the licensing guidelines [OK] * license matches upstream [OK] * %license is used [OK] * sources match [OK] * builds (into noarch) [OK] * build deps [OK] * locale [not applicable] * shared lib (ldconfig) [not applicable] * no bundled lib [OK] * relocatable [not applicable] * owning directories [OK] * files not listed more than once [OK] * permissions [OK] * macros [OK] * code/permissible content [OK] * documentation [OK] * static libs/dev files [not applicable] * no .la [OK] * GUI apps [not applicable] * not own other packages' files or directories [OK] * filesnames are UTF-8 [OK] * dependencies on deprecated packages [OK] Result: PASS. Please consider separating the doc files into a separate package. Considering the current size it is in no way necessary but please do it in a future release. SHOULD: * license [already in, OK] * mock [OK, see scratch above] All other SHOULD items are not applicable. Review result: PASS with a single, non-binding comment. Package is APPROVED for inclusion in Fedora. (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/ansible-freeipa |