Bug 1706787 - Review Request: ansible-freeipa - Roles and playbooks to deploy FreeIPA servers, replicas and clients
Summary: Review Request: ansible-freeipa - Roles and playbooks to deploy FreeIPA serve...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: François Cami
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-05-06 10:19 UTC by Thomas Woerner
Modified: 2019-05-09 14:34 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-05-09 14:34:31 UTC
Type: ---
Embargoed:
fdc: fedora-review+


Attachments (Terms of Use)

Description Thomas Woerner 2019-05-06 10:19:16 UTC
Spec URL: http://people.redhat.com/twoerner/ansible-freeipa/ansible-freeipa.spec
SRPM URL: http://people.redhat.com/twoerner/ansible-freeipa/ansible-freeipa-0.1.1-1.fc29.src.rpm
Description: Roles and playbooks to deploy FreeIPA servers, replicas and clients
Fedora Account System Username: twoerner

Comment 1 François Cami 2019-05-08 22:13:37 UTC
Taken. Expect a review with 24 hours.

Comment 2 François Cami 2019-05-09 09:26:23 UTC
Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=34742464

rpmlint output (warnings are spurious):
$ rpmlint ansible-freeipa.spec  ansible-freeipa-0.1.1-1.fc30.noarch.rpm ansible-freeipa-0.1.1-1.fc30.src.rpm
ansible-freeipa.noarch: W: spelling-error %description -l en_US gssapi -> sapping
ansible-freeipa.src: W: spelling-error %description -l en_US gssapi -> sapping
2 packages and 1 specfiles checked; 0 errors, 2 warnings.

Comment 3 François Cami 2019-05-09 09:45:49 UTC
MUST:
* rpmlint [OK]
* naming [OK]
* spec file naming [OK]
* Packaging Guidelines [OK] with no remark
* license within the licensing guidelines [OK]
* license matches upstream [OK]
* %license is used [OK]
* sources match [OK]
* builds (into noarch) [OK]
* build deps [OK]
* locale [not applicable]
* shared lib (ldconfig) [not applicable]
* no bundled lib [OK]
* relocatable [not applicable]
* owning directories [OK]
* files not listed more than once [OK]
* permissions [OK]
* macros [OK]
* code/permissible content [OK]
* documentation [OK]
* static libs/dev files [not applicable]
* no .la [OK]
* GUI apps [not applicable]
* not own other packages' files or directories [OK]
* filesnames are UTF-8 [OK]
* dependencies on deprecated packages [OK]

Result: PASS. Please consider separating the doc files into a separate package. Considering the current size it is in no way necessary but please do it in a future release.

SHOULD:
* license [already in, OK]
* mock [OK, see scratch above]
All other SHOULD items are not applicable.

Comment 4 François Cami 2019-05-09 09:46:41 UTC
Review result: PASS with a single, non-binding comment. Package is APPROVED for inclusion in Fedora.

Comment 5 Gwyn Ciesla 2019-05-09 13:43:09 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/ansible-freeipa


Note You need to log in before you can comment on or make changes to this bug.