Bug 1707532

Summary: Review Request: rpminspect - Build deviation compliance tool
Product: [Fedora] Fedora Reporter: Dave Cantrell <dcantrell>
Component: Package ReviewAssignee: David Shea <dshea>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: dshea, package-review
Target Milestone: ---Flags: dshea: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-05-23 16:27:28 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
review.txt
none
review.txt none

Description Dave Cantrell 2019-05-07 17:38:17 UTC 
Spec URL: https://dcantrel.fedorapeople.org/rpminspect/rpminspect.spec
SRPM URL: https://dcantrel.fedorapeople.org/rpminspect/rpminspect-1.0-0.1557172836.fc31.src.rpm

Description:
Build deviation and compliance tool.  This program runs a number of tests
against one or two builds of source RPM files.  The built artifacts are
inspected and compared to report changes and validate policy compliance
against the defined parameters.

Fedora Account System Username: dcantrel
Comment 1 David Shea 2019-05-07 19:21:28 UTC 
Created attachment 1565333 [details]
review.txt

fedora-review output attached. Here's a summary of the problems:

* COPYING should be listed as %license under %files, and needs to be at a minimum listed in the librpminspect and rpminspect-data-generic subpackages

* /etc/rpminspect needs to be owned by rpminspect-data-generic

* No need to "Requires: librpminspect" from rpminspect, rpmbuild picks up the .so requires

* The "Requires: librpminspect = ..." in librpmsinspect-devel needs to be "Requires: librpminspect%{?_isa} = ..."

* %defattr isn't needed anymore, that went away in RHEL-6

* use %make_build instead of %{__make}

* librpminspect.so has an executable stack, which was probably my fault. Looking into it.
Comment 2 Dave Cantrell 2019-05-08 15:56:53 UTC 
Made changes and have a new build ready for review again:

https://dcantrel.fedorapeople.org/rpminspect/rpminspect.spec
https://dcantrel.fedorapeople.org/rpminspect/rpminspect-1.0-1.1557324739.fc31.src.rpm
Comment 3 David Shea 2019-05-08 17:09:35 UTC 
Created attachment 1565741 [details]
review.txt
Comment 4 David Shea 2019-05-08 17:09:53 UTC 
PASS
Comment 5 Gwyn Ciesla 2019-05-22 20:01:59 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rpminspect