Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://dcantrel.fedorapeople.org/rpminspect/rpminspect.spec SRPM URL: https://dcantrel.fedorapeople.org/rpminspect/rpminspect-1.0-0.1557172836.fc31.src.rpm Description: Build deviation and compliance tool. This program runs a number of tests against one or two builds of source RPM files. The built artifacts are inspected and compared to report changes and validate policy compliance against the defined parameters. Fedora Account System Username: dcantrel
Created attachment 1565333 [details] review.txt fedora-review output attached. Here's a summary of the problems: * COPYING should be listed as %license under %files, and needs to be at a minimum listed in the librpminspect and rpminspect-data-generic subpackages * /etc/rpminspect needs to be owned by rpminspect-data-generic * No need to "Requires: librpminspect" from rpminspect, rpmbuild picks up the .so requires * The "Requires: librpminspect = ..." in librpmsinspect-devel needs to be "Requires: librpminspect%{?_isa} = ..." * %defattr isn't needed anymore, that went away in RHEL-6 * use %make_build instead of %{__make} * librpminspect.so has an executable stack, which was probably my fault. Looking into it.
Made changes and have a new build ready for review again: https://dcantrel.fedorapeople.org/rpminspect/rpminspect.spec https://dcantrel.fedorapeople.org/rpminspect/rpminspect-1.0-1.1557324739.fc31.src.rpm
Created attachment 1565741 [details] review.txt
PASS
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rpminspect