Bug 1707746

Summary: AFR-v2 does not log before attempting data self-heal
Product: [Community] GlusterFS Reporter: Ravishankar N <ravishankar>
Component: replicateAssignee: Ravishankar N <ravishankar>
Status: CLOSED NEXTRELEASE QA Contact:
Severity: low Docs Contact:
Priority: unspecified    
Version: mainlineCC: bugs
Target Milestone: ---Keywords: Triaged
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-05-08 13:26:59 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Ravishankar N 2019-05-08 09:03:44 UTC
afr: log before attempting data self-heal.

    I was working on a blog about troubleshooting AFR issues and I wanted to copy
    the messages logged by self-heal for my blog. I then realized that AFR-v2 is not
    logging *before* attempting data heal while it logs it for metadata and entry
    heals.

    I [MSGID: 108026] [afr-self-heal-entry.c:883:afr_selfheal_entry_do]
    0-testvol-replicate-0: performing entry selfheal on
    d120c0cf-6e87-454b-965b-0d83a4c752bb
    I [MSGID: 108026] [afr-self-heal-common.c:1741:afr_log_selfheal]
    0-testvol-replicate-0: Completed entry selfheal on
    d120c0cf-6e87-454b-965b-0d83a4c752bb. sources=[0] 2  sinks=1
    I [MSGID: 108026] [afr-self-heal-common.c:1741:afr_log_selfheal]
    0-testvol-replicate-0: Completed data selfheal on
    a9b5f183-21eb-4fb3-a342-287d3a7dddc5. sources=[0] 2  sinks=1
    I [MSGID: 108026] [afr-self-heal-metadata.c:52:__afr_selfheal_metadata_do]
    0-testvol-replicate-0: performing metadata selfheal on
    a9b5f183-21eb-4fb3-a342-287d3a7dddc5
    I [MSGID: 108026] [afr-self-heal-common.c:1741:afr_log_selfheal]
    0-testvol-replicate-0: Completed metadata selfheal on
    a9b5f183-21eb-4fb3-a342-287d3a7dddc5. sources=[0] 2  sinks=1

    Adding it in this patch. Now there is a 'performing' and a corresponding
    'Completed' message for every type of heal.

Comment 1 Worker Ant 2019-05-08 09:07:43 UTC
REVIEW: https://review.gluster.org/22685 (afr: log before attempting data self-heal.) posted (#1) for review on master by Ravishankar N

Comment 2 Worker Ant 2019-05-08 13:26:59 UTC
REVIEW: https://review.gluster.org/22685 (afr: log before attempting data self-heal.) merged (#2) on master by Pranith Kumar Karampuri