Bug 1707746 - AFR-v2 does not log before attempting data self-heal
Summary: AFR-v2 does not log before attempting data self-heal
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: replicate
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
low
Target Milestone: ---
Assignee: Ravishankar N
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-05-08 09:03 UTC by Ravishankar N
Modified: 2019-05-08 13:26 UTC (History)
1 user (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2019-05-08 13:26:59 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Gluster.org Gerrit 22685 0 None Merged afr: log before attempting data self-heal. 2019-05-08 13:26:58 UTC

Description Ravishankar N 2019-05-08 09:03:44 UTC
afr: log before attempting data self-heal.

    I was working on a blog about troubleshooting AFR issues and I wanted to copy
    the messages logged by self-heal for my blog. I then realized that AFR-v2 is not
    logging *before* attempting data heal while it logs it for metadata and entry
    heals.

    I [MSGID: 108026] [afr-self-heal-entry.c:883:afr_selfheal_entry_do]
    0-testvol-replicate-0: performing entry selfheal on
    d120c0cf-6e87-454b-965b-0d83a4c752bb
    I [MSGID: 108026] [afr-self-heal-common.c:1741:afr_log_selfheal]
    0-testvol-replicate-0: Completed entry selfheal on
    d120c0cf-6e87-454b-965b-0d83a4c752bb. sources=[0] 2  sinks=1
    I [MSGID: 108026] [afr-self-heal-common.c:1741:afr_log_selfheal]
    0-testvol-replicate-0: Completed data selfheal on
    a9b5f183-21eb-4fb3-a342-287d3a7dddc5. sources=[0] 2  sinks=1
    I [MSGID: 108026] [afr-self-heal-metadata.c:52:__afr_selfheal_metadata_do]
    0-testvol-replicate-0: performing metadata selfheal on
    a9b5f183-21eb-4fb3-a342-287d3a7dddc5
    I [MSGID: 108026] [afr-self-heal-common.c:1741:afr_log_selfheal]
    0-testvol-replicate-0: Completed metadata selfheal on
    a9b5f183-21eb-4fb3-a342-287d3a7dddc5. sources=[0] 2  sinks=1

    Adding it in this patch. Now there is a 'performing' and a corresponding
    'Completed' message for every type of heal.

Comment 1 Worker Ant 2019-05-08 09:07:43 UTC
REVIEW: https://review.gluster.org/22685 (afr: log before attempting data self-heal.) posted (#1) for review on master by Ravishankar N

Comment 2 Worker Ant 2019-05-08 13:26:59 UTC
REVIEW: https://review.gluster.org/22685 (afr: log before attempting data self-heal.) merged (#2) on master by Pranith Kumar Karampuri


Note You need to log in before you can comment on or make changes to this bug.