Bug 170905

Summary:	Review Request: pcsc-tools
Product:	[Fedora] Fedora	Reporter:	Ville Skyttä <scop>
Component:	Package Review	Assignee:	John Mahowald <jpmahowald>
Status:	CLOSED NEXTRELEASE	QA Contact:	David Lawrence <dkl>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-extras-list
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
URL:	http://ludovic.rousseau.free.fr/softwares/pcsc-tools/
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2005-12-13 21:15:35 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	163779

Description Ville Skyttä 2005-10-15 12:19:21 UTC

http://cachalot.mine.nu/4/SRPMS/pcsc-tools-1.4.1-0.2.src.rpm

The pcsc-tools package contains some tools useful for a user of PC/SC
user. The tools provided are:
* pcsc_scan(1) scans available smart card readers and print detected
  events: card insertion with ATR, card removal;
* ATR_analysis(1) analyses a smart card ATR (Anwser To Reset)
* scriptor(1) Perl script to send commands to a smart card using a
  batch file or stdin;
* gscriptor(1) the same idea as scriptor(1) but with Perl-Gtk GUI.

Comment 1 John Mahowald 2005-12-13 05:17:48 UTC

Courtesy of fedora-qa script:
* RPM name is OK
* Source pcsc-tools-1.4.1.tar.gz is the same as upstream
* Builds fine in mock, FC4 i386
* rpmlint of pcsc-tools looks OK
* File list of pcsc-tools looks OK

Needs work:
* Source smartcard_list.txt is different from upstream,
  upstream is newer
  (wiki: QAChecklist item 2)
* BuildRequires: sed should not be included
  (wiki: PackagingGuidelines#Exceptions)
* Desktop file: the Categories tag should contain Application
  (wiki: PackagingGuidelines#desktop)

Comment 2 Ville Skyttä 2005-12-13 09:14:26 UTC

Thanks.  smartcard_list.txt is a moving target, updated to latest upstream and
"fixed" the other issues too (although I don't quite agree with them).

http://cachalot.mine.nu/4/SRPMS/pcsc-tools-1.4.1-1.src.rpm

Comment 3 John Mahowald 2005-12-13 20:28:14 UTC

- package meets naming guidelines
- package meets packaging guidelines
- license (GPL) OK, text in %doc, matches source
- spec file legible
- source matches upstream
- package compiles on FC4 i386
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- .desktop file properly installed

APPROVED

Comment 4 Ville Skyttä 2005-12-13 21:15:35 UTC

Thanks, imported and successfully built for FC-4 and devel.