Red Hat Bugzilla – Bug 170905
Review Request: pcsc-tools
Last modified: 2007-11-30 17:11:15 EST
http://cachalot.mine.nu/4/SRPMS/pcsc-tools-1.4.1-0.2.src.rpm The pcsc-tools package contains some tools useful for a user of PC/SC user. The tools provided are: * pcsc_scan(1) scans available smart card readers and print detected events: card insertion with ATR, card removal; * ATR_analysis(1) analyses a smart card ATR (Anwser To Reset) * scriptor(1) Perl script to send commands to a smart card using a batch file or stdin; * gscriptor(1) the same idea as scriptor(1) but with Perl-Gtk GUI.
Courtesy of fedora-qa script: * RPM name is OK * Source pcsc-tools-1.4.1.tar.gz is the same as upstream * Builds fine in mock, FC4 i386 * rpmlint of pcsc-tools looks OK * File list of pcsc-tools looks OK Needs work: * Source smartcard_list.txt is different from upstream, upstream is newer (wiki: QAChecklist item 2) * BuildRequires: sed should not be included (wiki: PackagingGuidelines#Exceptions) * Desktop file: the Categories tag should contain Application (wiki: PackagingGuidelines#desktop)
Thanks. smartcard_list.txt is a moving target, updated to latest upstream and "fixed" the other issues too (although I don't quite agree with them). http://cachalot.mine.nu/4/SRPMS/pcsc-tools-1.4.1-1.src.rpm
- package meets naming guidelines - package meets packaging guidelines - license (GPL) OK, text in %doc, matches source - spec file legible - source matches upstream - package compiles on FC4 i386 - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - .desktop file properly installed APPROVED
Thanks, imported and successfully built for FC-4 and devel.