Bug 1710791

Summary:	fedora-review throws TypeError: must be str or None, not bytes
Product:	[Fedora] Fedora	Reporter:	Andy Li <andy>
Component:	fedora-review	Assignee:	Stanislav Ochotnicky <sochotni>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	31	CC:	admiller, leamas.alec, ngompa13, pingou, rjones, sochotni
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	fedora-review-0.7.3-1.fc30 fedora-review-0.7.3-1.fc31 fedora-review-0.7.3-1.fc29	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-09-24 01:08:40 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Andy Li 2019-05-16 10:26:47 UTC

Description of problem:
Running `fedora-review -n ...` results in error "TypeError: must be str or None, not bytes".

Version-Release number of selected component (if applicable):
fedora-review version 0.7.2 65d36bb 2019-04-09 16:30:26 -0400

How reproducible:
always

Steps to Reproduce:
1. Clone https://gist.github.com/andyli/28e66c5757e31b04951bb38300398fbb
2. Run `fedora-review -n ocaml-ppx-derivers`

Actual results:
ERROR: Exception down the road... (logs in /home/user/.cache/fedora-review.log)

fedora-review.log: https://gist.github.com/andyli/ede70f71d66c370702307b343e13ca17

Expected results:
No error.

Additional info:
N/A

Comment 1 Ben Cotton 2019-08-13 16:53:51 UTC

This bug appears to have been reported against 'rawhide' during the Fedora 31 development cycle.
Changing version to '31'.

Comment 2 Ben Cotton 2019-08-13 19:19:40 UTC

This bug appears to have been reported against 'rawhide' during the Fedora 31 development cycle.
Changing version to 31.

Comment 3 Richard W.M. Jones 2019-09-10 14:47:18 UTC

Happens in fedora-review-0.7.2-2.fc31.noarch

Comment 4 Richard W.M. Jones 2019-09-10 14:53:49 UTC

Fix here: https://bugzilla.redhat.com/show_bug.cgi?id=1741527#c4

Comment 5 Fedora Update System 2019-09-19 01:56:10 UTC

FEDORA-2019-596b8978cd has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-596b8978cd

Comment 6 Fedora Update System 2019-09-19 01:56:14 UTC

FEDORA-2019-5864ffc7d1 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-5864ffc7d1

Comment 7 Fedora Update System 2019-09-20 01:56:27 UTC

fedora-review-0.7.3-1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-5864ffc7d1

Comment 8 Fedora Update System 2019-09-20 02:56:22 UTC

fedora-review-0.7.3-1.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-ec5a783a3c

Comment 9 Fedora Update System 2019-09-20 03:01:42 UTC

fedora-review-0.7.3-1.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-596b8978cd

Comment 10 Fedora Update System 2019-09-24 01:08:40 UTC

fedora-review-0.7.3-1.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.

Comment 11 Fedora Update System 2019-09-28 00:02:10 UTC

fedora-review-0.7.3-1.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.

Comment 12 Fedora Update System 2019-09-28 01:56:04 UTC

fedora-review-0.7.3-1.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.