I've been seeing this failure for some time (e.g. with -b 1737580 just now): 08-15 11:26 root DEBUG Exception down the road... Traceback (most recent call last): File "/usr/lib/python3.7/site-packages/FedoraReview/review_helper.py", line 236, in run self._do_run(outfile) File "/usr/lib/python3.7/site-packages/FedoraReview/review_helper.py", line 226, in _do_run self._do_report(outfile) File "/usr/lib/python3.7/site-packages/FedoraReview/review_helper.py", line 99, in _do_report self._run_checks(self.bug.spec_file, self.bug.srpm_file, outfile) File "/usr/lib/python3.7/site-packages/FedoraReview/review_helper.py", line 108, in _run_checks self.checks = Checks(spec, srpm) File "/usr/lib/python3.7/site-packages/FedoraReview/checks.py", line 280, in __init__ self.spec = SpecFile(spec_file, self.flags) File "/usr/lib/python3.7/site-packages/FedoraReview/spec_file.py", line 89, in __init__ self.expand_tag(rpm.RPMTAG_NAME).decode("utf-8"), AttributeError: 'str' object has no attribute 'decode' Running with LC_ALL=C, rather than my default of en_GB.UTF-8, fails similarly. This is with fedora-review-0.7.2-2.fc31.
Workaround is --no-scratch-build
Can confirm this happens for me with the same version (fedora-review-0.7.2-2.fc31.noarch)
The workaround for me was to hand edit /usr/lib/python3.7/site-packages/FedoraReview/spec_file.py and remove every place it says .decode("utf-8") (of which there are many).
Created attachment 1613627 [details] Patch Patch which fixes this bug and bug 1710791 as well.
Created attachment 1613628 [details] Patch Let's try that again, but this time without reversing the patch.
You'll also need to remove .decode("utf-8") calls in /usr/lib/python3.7/site-packages/FedoraReview/rpm_file.py
FEDORA-2019-ec5a783a3c has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-ec5a783a3c
FEDORA-2019-5864ffc7d1 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-5864ffc7d1
FEDORA-2019-596b8978cd has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-596b8978cd
fedora-review-0.7.3-1.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.
fedora-review-0.7.3-1.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.
fedora-review-0.7.3-1.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.