Bug 1710837

Summary:	Feature gate machine healthcheck controller with cluster feature gate
Product:	OpenShift Container Platform	Reporter:	Jan Chaloupka <jchaloup>
Component:	Cloud Compute	Assignee:	Jan Chaloupka <jchaloup>
Status:	CLOSED ERRATA	QA Contact:	Jianwei Hou <jhou>
Severity:	high	Docs Contact:
Priority:	high
Version:	4.1.0	CC:	agarcial, gblomqui
Target Milestone:	---
Target Release:	4.1.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-06-04 10:48:49 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jan Chaloupka 2019-05-16 12:11:15 UTC

Description of problem:
All extra features are gated by `cluster` feature gate key. Health checking feature is gated by `machine-api` key. Given all components are expecting `cluster` key, we need to do the same.

Comment 1 Jan Chaloupka 2019-05-16 12:11:36 UTC

4.1: https://github.com/openshift/machine-api-operator/pull/318
master: https://github.com/openshift/machine-api-operator/pull/317

Comment 3 Jianwei Hou 2019-05-20 05:40:43 UTC

Verified in 4.1.0-rc.5


Enabling machine-healthcheck with
```
apiVersion: config.openshift.io/v1
kind: FeatureGate
metadata:
  annotations:
    release.openshift.io/create-only: "true"
  creationTimestamp: "2019-05-20T03:15:02Z"
  generation: 2
  name: cluster
  resourceVersion: "44796"
  selfLink: /apis/config.openshift.io/v1/featuregates/cluster
  uid: 753f6c70-7aad-11e9-99f2-064df673d19e
spec:
  featureSet: TechPreviewNoUpgrade
```

oc get pod machine-api-controllers-84b44d48f7-z7zpc
NAME                                       READY   STATUS    RESTARTS   AGE
machine-api-controllers-84b44d48f7-z7zpc   4/4     Running   0          75s


--------
Disabling machine-healthcheck with
```
apiVersion: config.openshift.io/v1
kind: FeatureGate
metadata:
  annotations:
    release.openshift.io/create-only: "true"
  creationTimestamp: "2019-05-20T03:15:02Z"
  generation: 3
  name: cluster
  resourceVersion: "46260"
  selfLink: /apis/config.openshift.io/v1/featuregates/cluster
  uid: 753f6c70-7aad-11e9-99f2-064df673d19e
spec: {}
```

Once it's disabled, delete the machine-api-controllers deployment so that the machine-healthcheck-controller is removed(Automatic removal is tracked by https://bugzilla.redhat.com/show_bug.cgi?id=1710172).
oc get pods machine-api-controllers-749bdc5684-lst9s
NAME                                       READY   STATUS    RESTARTS   AGE
machine-api-controllers-749bdc5684-lst9s   3/3     Running   1          117s

Comment 5 errata-xmlrpc 2019-06-04 10:48:49 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:0758