Bug 1712012

Summary: python-units FTBFS with pytest4
Product: [Fedora] Fedora Reporter: Patrik Kopkan <pkopkan>
Component: python-unitsAssignee: Igor Raits <igor.raits>
Status: CLOSED WONTFIX QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: high Docs Contact:
Priority: unspecified    
Version: rawhideCC: igor.raits, mhroncok
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-07-28 16:05:01 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1700317, 1671167, 1686977, 1732841    
Attachments:
Description Flags
Copr build log none

Description Patrik Kopkan 2019-05-20 15:31:00 UTC 
Created attachment 1571323 [details]
Copr build log

python-units-0.07-8 fails at collection(generating) of tests. Metafunc.addcall is removed  https://docs.pytest.org/en/latest/deprecations.html#metafunc-addcall. Use instead metafunc.parametrize()


==================================== ERRORS ====================================
______________ ERROR collecting units/tests/test_inequalities.py _______________
tests/test_inequalities.py:160: in pytest_generate_tests
    metafunc.addcall(funcargs=dict(quant1=lesser, quant2=greater))
E   AttributeError: 'Metafunc' object has no attribute 'addcall'
!!!!!!!!!!!!!!!!!!! Interrupted: 1 errors during collection !!!!!!!!!!!!!!!!!!!!
=========================== 1 error in 0.38 seconds ============================
error: Bad exit status from /var/tmp/rpm-tmp.YPbMrt (%check)
    Bad exit status from /var/tmp/rpm-tmp.YPbMrt (%check)
Comment 1 Miro Hrončok 2019-07-10 11:43:17 UTC 
This blocks the Python 3.8 rebuild. Igor, please respond.
Comment 2 Igor Raits 2019-07-28 14:38:59 UTC 
I could not find way to report issue to upstream. https://bitbucket.org/adonohue/units/src/default/ seems to have issues disabled. Upstream seems to be dead pretty much.

I think I can disable tests. What do you think?
Comment 3 Miro Hrončok 2019-07-28 15:48:36 UTC 
I think we should not ship dead software. Let's retire it?
Comment 4 Igor Raits 2019-07-28 16:05:01 UTC 
Ack.

Retired.