Bug 1712890
| Summary: | engine-setup should check for snapshots in unsupported CL | |||
|---|---|---|---|---|
| Product: | Red Hat Enterprise Virtualization Manager | Reporter: | Marina Kalinin <mkalinin> | |
| Component: | ovirt-engine | Assignee: | Yedidyah Bar David <didi> | |
| Status: | CLOSED ERRATA | QA Contact: | Petr Matyáš <pmatyas> | |
| Severity: | high | Docs Contact: | ||
| Priority: | high | |||
| Version: | 4.3.0 | CC: | didi, lleistne, michal.skrivanek, mtessun, rdlugyhe | |
| Target Milestone: | ovirt-4.4.0 | Keywords: | ZStream | |
| Target Release: | --- | |||
| Hardware: | Unspecified | |||
| OS: | Unspecified | |||
| Whiteboard: | ||||
| Fixed In Version: | Doc Type: | Enhancement | ||
| Doc Text: |
With this update, when you upgrade RHV, engine-setup notifies you if virtual machines in the environment have snapshots whose cluster levels are incompatible with the RHV version you are upgrading to. It is safe to let it proceed, but it is not safe to use these snapshots after the upgrade. For example, it is not safe to preview these snapshots.
There is an exception to the above: engine-setup does not notify you if the virtual machine is running the {engine-name} as a self-hosted engine. For hosted-engine, it provides an automatic "Yes" and upgrades the virtual machine without prompting or notifying you. It is unsafe to use snapshots of the hosted-engine virtual machine after the upgrade.
|
Story Points: | --- | |
| Clone Of: | ||||
| : | 1715877 (view as bug list) | Environment: | ||
| Last Closed: | 2020-08-04 13:19:21 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | Integration | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | ||||
| Bug Blocks: | 1715877 | |||
|
Description
Marina Kalinin
2019-05-22 12:28:56 UTC
Michal, can you please provide the exact requirements here to detect when the CL will not be supported in the new version? similar to existing stuff in https://github.com/oVirt/ovirt-engine/blob/master/packaging/setup/plugins/ovirt-engine-checks/ovirt-engine/db/versions.py it just should go through the snapshots in addition (In reply to Marina Kalinin from comment #0) > engine-setup should check for snapshots in unsupported CL, let the user know > about this + provide the ability to stop the upgrade, if user decides so. Text? Perhaps some link to more information? E.g. what specific actions will not work if you do upgrade? What happens if you still tries these actions (IIRC I lost VMs in the past by trying to preview such snapshots)? Default to "No" (abort setup)? If user says "Yes", ask again to confirm? (In reply to Michal Skrivanek from comment #2) > similar to existing stuff in > https://github.com/oVirt/ovirt-engine/blob/master/packaging/setup/plugins/ > ovirt-engine-checks/ovirt-engine/db/versions.py > it just should go through the snapshots in addition Now created a snapshot, and the only place in the db where I can see the compatibility level of that snapshot is in the xml dump of the vm in vm_configuration (in table "snapshots"). Is it indeed the only place? And I should parse the xml for each snapshot, checking "/ovf:Envelope/Content/ClusterCompatibilityVersion" for each, comparing with current version? yes, that is correct we should add that to rhv-log-collector-analyzer as well Verified on ovirt-engine-4.4.0-0.6.master.el7.noarch WARN: Bug status (VERIFIED) wasn't changed but the folowing should be fixed:
[Found non-acked flags: '{}', ]
For more info please contact: rhv-devops: Bug status (VERIFIED) wasn't changed but the folowing should be fixed:
[Found non-acked flags: '{}', ]
For more info please contact: rhv-devops
WARN: Bug status (VERIFIED) wasn't changed but the folowing should be fixed:
[Found non-acked flags: '{}', ]
For more info please contact: rhv-devops: Bug status (VERIFIED) wasn't changed but the folowing should be fixed:
[Found non-acked flags: '{}', ]
For more info please contact: rhv-devops
WARN: Bug status (VERIFIED) wasn't changed but the folowing should be fixed:
[Found non-acked flags: '{}', ]
For more info please contact: rhv-devops: Bug status (VERIFIED) wasn't changed but the folowing should be fixed:
[Found non-acked flags: '{}', ]
For more info please contact: rhv-devops
WARN: Bug status (VERIFIED) wasn't changed but the folowing should be fixed:
[Found non-acked flags: '{}', ]
For more info please contact: rhv-devops: Bug status (VERIFIED) wasn't changed but the folowing should be fixed:
[Found non-acked flags: '{}', ]
For more info please contact: rhv-devops
WARN: Bug status (VERIFIED) wasn't changed but the folowing should be fixed:
[Found non-acked flags: '{}', ]
For more info please contact: rhv-devops: Bug status (VERIFIED) wasn't changed but the folowing should be fixed:
[Found non-acked flags: '{}', ]
For more info please contact: rhv-devops
In a private discussion we decided to include the hosted-engine case in the doc-text of current bug, instead of partially duplicating it for bug 1822535. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (Important: RHV Manager (ovirt-engine) 4.4 security, bug fix, and enhancement update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2020:3247 |