If a VM has a snapshot made in DC compatibility level that is not supported by the version we are upgrading to, the snapshot would not be usable in that version. engine-setup should check for snapshots in unsupported CL, let the user know about this + provide the ability to stop the upgrade, if user decides so. For example, if a VM has a snapshot created in 4.0, and engine-setup is upgrading to CL 4.3, it should detect those snapshots and let the user know.
Michal, can you please provide the exact requirements here to detect when the CL will not be supported in the new version?
similar to existing stuff in https://github.com/oVirt/ovirt-engine/blob/master/packaging/setup/plugins/ovirt-engine-checks/ovirt-engine/db/versions.py it just should go through the snapshots in addition
(In reply to Marina Kalinin from comment #0) > engine-setup should check for snapshots in unsupported CL, let the user know > about this + provide the ability to stop the upgrade, if user decides so. Text? Perhaps some link to more information? E.g. what specific actions will not work if you do upgrade? What happens if you still tries these actions (IIRC I lost VMs in the past by trying to preview such snapshots)? Default to "No" (abort setup)? If user says "Yes", ask again to confirm?
(In reply to Michal Skrivanek from comment #2) > similar to existing stuff in > https://github.com/oVirt/ovirt-engine/blob/master/packaging/setup/plugins/ > ovirt-engine-checks/ovirt-engine/db/versions.py > it just should go through the snapshots in addition Now created a snapshot, and the only place in the db where I can see the compatibility level of that snapshot is in the xml dump of the vm in vm_configuration (in table "snapshots"). Is it indeed the only place? And I should parse the xml for each snapshot, checking "/ovf:Envelope/Content/ClusterCompatibilityVersion" for each, comparing with current version?
yes, that is correct we should add that to rhv-log-collector-analyzer as well
Verified on ovirt-engine-4.4.0-0.6.master.el7.noarch
WARN: Bug status (VERIFIED) wasn't changed but the folowing should be fixed: [Found non-acked flags: '{}', ] For more info please contact: rhv-devops: Bug status (VERIFIED) wasn't changed but the folowing should be fixed: [Found non-acked flags: '{}', ] For more info please contact: rhv-devops
In a private discussion we decided to include the hosted-engine case in the doc-text of current bug, instead of partially duplicating it for bug 1822535.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (Important: RHV Manager (ovirt-engine) 4.4 security, bug fix, and enhancement update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2020:3247