Bug 1715388
| Summary: | [machines]The storage pool whose creation was failed is still be added | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 8 | Reporter: | YunmingYang <yunyang> |
| Component: | cockpit-appstream | Assignee: | Katerina Koukiou <kkoukiou> |
| Status: | CLOSED ERRATA | QA Contact: | YunmingYang <yunyang> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 8.1 | CC: | leiwang, mmarusak, mpitt, qiyuan, wchadwic, wshi, xchen |
| Target Milestone: | rc | Keywords: | Rebase |
| Target Release: | 8.2 | Flags: | pm-rhel:
mirror+
|
| Hardware: | x86_64 | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2019-11-05 20:41:55 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
YunmingYang
2019-05-30 08:57:38 UTC
This was fixed recently with:
commit 182f70fd8da2d06342ceaf4c322131f2fe17ad3c
Author: Katerina Koukiou <kkoukiou>
Date: Mon May 20 14:55:53 2019 +0200
machines: when a storage pool failed to get active undefine it directly
$ git describe 182f70fd8da2d06342ceaf4c322131f2fe17ad3c
194-46-g182f70fd8
It's fixed with cockpit-machines-195. This is not available yet in latest-RHEL-8 though.
Test Versions: cockpit-machines-196-1.el8.noarch libvirt-dbus-1.2.0-2.module+el8.1.0+2983+b2ae9c0a.x86_64 Test Steps: 1. Create a 'Network File System' storage pool with using 'QEMU/KVM User connection' 2. Make sure the result with command which is 'virsh pool-list --all' Test Results: The storage pool whose creation is failed didn't appear. According to the results, move the status to VERIFIED. For the record, there is a proper fix now: https://github.com/cockpit-project/cockpit/pull/12635 This should now be fixed properly in 197.3-1, in https://errata.devel.redhat.com/advisory/40553 . Can you please re-test? Hi @Martin, I test with 197.3-1, but it seems that the issue still exist, but the issue disappear in the 202-1(upstream version). Then I checked the https://github.com/cockpit-project/cockpit/blob/rhel-8.1/pkg/machines/components/storagePools/storagePoolList.jsx and it seems that the fix in https://github.com/cockpit-project/cockpit/pull/12635 are not there. @Yunming: cockpit-appstream is built from the "rhel-8-appstream" branch, not the "rhel-8.1" branch. https://github.com/cockpit-project/cockpit/blob/rhel-8-appstream/pkg/machines/components/storagePools/storagePoolList.jsx does have that fix (and it's included in 197.3). @Martin many thanks, but I tested it in 197.3 again, the issue can be still reproduced. Hmm, Katerina/Simon, do you know what other commit/PR we need to backport for this? It's the following commit which was missing from rhel-8-appstream branch:
commit afae77cce1c015b95f75a5e87050003dc940f97b
Author: Katerina Koukiou <kkoukiou>
Date: Mon Jul 15 11:51:57 2019 +0200
machines: add missing updateOnly parameter in getStoragePool action
I cherry-picked it from master in this PR https://github.com/cockpit-project/cockpit/pull/12848
Thanks Katerina! I'll update the 8.1 package with this fix early next week. OK, moving to 8.2 then. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2019:3325 |