RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1715388 - [machines]The storage pool whose creation was failed is still be added
Summary: [machines]The storage pool whose creation was failed is still be added
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 8
Classification: Red Hat
Component: cockpit-appstream
Version: 8.1
Hardware: x86_64
OS: Linux
unspecified
medium
Target Milestone: rc
: 8.2
Assignee: Katerina Koukiou
QA Contact: YunmingYang
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-05-30 08:57 UTC by YunmingYang
Modified: 2019-11-05 20:42 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-11-05 20:41:55 UTC
Type: Bug
Target Upstream Version:
Embargoed:
pm-rhel: mirror+

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2019:3325 0 None None None 2019-11-05 20:42:06 UTC

Description YunmingYang 2019-05-30 08:57:38 UTC 
Description of problem:
If the storage pool creation was failed, the storage pool will be still added on the storage pool page, and its state is inactive.


Version-Release number of selected component (if applicable):
cockpit-machines-193-1.el8.noarch
libvirt-dbus-1.2.0-2.module+el8.1.0+2983+b2ae9c0a.x86_64

How reproducible:
100%

Steps to Reproduce:
1. Create a 'Network File System' storage pool with using 'QEMU/KVM User connection'
2. Make sure the result with command which is 'virsh pool-list --all'

Actual results:
1. There will be an error shown on the dialog.
2. The storage pool whose creation was failed is also added on the page, the state of it is inactive.
3. The command can also get this storage pool.

Expected results:
1. There will be an error shown on the dialog.
2. The storage pool whose creation was failed should not be added on the page.
3. The command can not get this storage pool.

Additional info:
Comment 1 Katerina Koukiou 2019-05-31 16:08:12 UTC 
This was fixed recently with:
commit 182f70fd8da2d06342ceaf4c322131f2fe17ad3c
Author: Katerina Koukiou <kkoukiou>
Date:   Mon May 20 14:55:53 2019 +0200

    machines: when a storage pool failed to get active undefine it directly

$ git describe 182f70fd8da2d06342ceaf4c322131f2fe17ad3c
194-46-g182f70fd8


It's fixed with cockpit-machines-195. This is not available yet in latest-RHEL-8 though.
Comment 3 YunmingYang 2019-06-20 03:20:18 UTC 
Test Versions:
cockpit-machines-196-1.el8.noarch
libvirt-dbus-1.2.0-2.module+el8.1.0+2983+b2ae9c0a.x86_64


Test Steps:
1. Create a 'Network File System' storage pool with using 'QEMU/KVM User connection'
2. Make sure the result with command which is 'virsh pool-list --all'


Test Results:
The storage pool whose creation is failed didn't appear.


According to the results, move the status to VERIFIED.
Comment 11 Martin Pitt 2019-08-29 15:57:08 UTC 
For the record, there is a proper fix now: https://github.com/cockpit-project/cockpit/pull/12635
Comment 13 Martin Pitt 2019-09-09 14:12:46 UTC 
This should now be fixed properly in 197.3-1, in https://errata.devel.redhat.com/advisory/40553 . Can you please re-test?
Comment 14 YunmingYang 2019-09-16 06:02:28 UTC 
Hi @Martin, I test with 197.3-1, but it seems that the issue still exist, but the issue disappear in the 202-1(upstream version). Then I checked the https://github.com/cockpit-project/cockpit/blob/rhel-8.1/pkg/machines/components/storagePools/storagePoolList.jsx and it seems that the fix in https://github.com/cockpit-project/cockpit/pull/12635 are not there.
Comment 15 Martin Pitt 2019-09-18 14:23:50 UTC 
@Yunming: cockpit-appstream is built from the "rhel-8-appstream" branch, not the "rhel-8.1" branch. https://github.com/cockpit-project/cockpit/blob/rhel-8-appstream/pkg/machines/components/storagePools/storagePoolList.jsx does have that fix (and it's included in 197.3).
Comment 16 YunmingYang 2019-09-19 07:33:09 UTC 
@Martin many thanks, but I tested it in 197.3 again, the issue can be still reproduced.
Comment 17 Martin Pitt 2019-09-19 08:25:55 UTC 
Hmm, Katerina/Simon, do you know what other commit/PR we need to backport for this?
Comment 18 Katerina Koukiou 2019-09-19 09:32:34 UTC 
It's the following commit which was missing from rhel-8-appstream branch:
commit afae77cce1c015b95f75a5e87050003dc940f97b
Author: Katerina Koukiou <kkoukiou>
Date:   Mon Jul 15 11:51:57 2019 +0200

    machines: add missing updateOnly parameter in getStoragePool action
    
I cherry-picked it from master in this PR https://github.com/cockpit-project/cockpit/pull/12848
Comment 19 Martin Pitt 2019-09-19 15:01:25 UTC 
Thanks Katerina! I'll update the 8.1 package with this fix early next week.
Comment 21 Martin Pitt 2019-09-20 07:48:21 UTC 
OK, moving to 8.2 then.
Comment 23 errata-xmlrpc 2019-11-05 20:41:55 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:3325
Note You need to log in before you can comment on or make changes to this bug.