Bug 171601

this is my first package, and I'm seeking a sponsor.

Needs work:
* BuildRequires: gcc and gcc-c++ should not be included
  (wiki: PackagingGuidelines#Exceptions)
* No downloadable source. Please give the full URL in the Source tag. You can
use http://download.softpedia.com/linux/yakuake-2.7.3.tar.bz2
* Add --disable-rpath and --disable-debug to %configure
* Add AUTHORS and COPYING as %doc
* don't package /usr/share/apps/yakuake/default/install.sh (useless and could be
misleading)
* Missing "gtk-update-icon-cache" in %post and %postun (wiki: ScriptletSnippets)
* Use desktop-file-install to install the desktop file
  (wiki: PackagingGuidelines#desktop)
* The directory %{_datadir}/apps/yakuake/ should be owned by the package
* Requires: kdelibs is superfluous, it will be picked up by rpm
* There is a typo in the summary

Minor:
* QT environment variable are not sourced, add
  unset QTDIR || : ; . /etc/profile.d/qt.sh
  export QTLIB=${QTDIR}/lib QTINC=${QTDIR}/include
  at the beginning of the %build section.

Ah, forget my comment about the install.sh script, it is useful. But chmod it
755 please.

ok back from holidays !

worked on all comments : please see 

http://mickael.bailly.free.fr/yakuake.spec
http://mickael.bailly.free.fr/yakuake-2.7.3-2.src.rpm

Thanks

(In reply to comment #3)
> Ah, forget my comment about the install.sh script, it is useful. But chmod it
> 755 please.

Needs work:
* Desktop file: the Categories tag should contain Application
  (wiki: PackagingGuidelines#desktop)

Minor:

* You can use "%doc AUTHORS COPYING" in the %files list, it will take care by
itself to create the directories in the buildroot, and to copy the files.
* You can use the "--delete-original" option of desktop-file-install to remove
the installed file, instead of doing it manually. The desktop-file-install call
could look like :
use desktop-file-install --vendor fedora \
    --dir ${RPM_BUILD_ROOT}%{_datadir}/applications \
    --add-category X-Fedora \
    --add-category Application \
    --delete-original \
    ${RPM_BUILD_ROOT}%{_datadir}/applnk/Utilities/yakuake.desktop

* The spec file is chmod +x.

The rest looks fine.

hello!,

fixed package following comment #5.

please see 

http://mickael.bailly.free.fr/yakuake.spec
http://mickael.bailly.free.fr/yakuake-2.7.3-3.src.rpm

Last thing : add these lines to the desktop-file-install call :
  --add-category Utility \
  --add-category KDE \
  --add-category Qt \
The 1st one is because Yakuake currently appears in the "Other" section of the
menu. The other make it not appear in GNOME, where it would be useless (it uses
dcop).

fixed.

Please see

http://mickael.bailly.free.fr/yakuake.spec
http://mickael.bailly.free.fr/yakuake-2.7.3-4.src.rpm

Review for release 4:
* RPM name is OK
* Source yakuake-2.7.3.tar.bz2 is the same as upstream
* Builds fine in mock
* rpmlint of yakuake looks OK
* File list of yakuake looks OK
* Works fine
APPROVED

Aurelien, are you sure that adding KDE/Qt categories would prevent the package  
from appearing in Gnome menus?  If that's true, I think something's abusing 
the categories. 
  
The correct way to prevent something from appearing in certain environment's 
menus or make it appear only in specified ones is to use NotShowIn and 
OnlyShowIn respectively. 
 
There's nothing wrong with adding the KDE/Qt categories though, but I think 
they'd be unused in FC currently. 
 
More info: 
http://standards.freedesktop.org/menu-spec/latest/ar01s03.html 
http://standards.freedesktop.org/menu-spec/latest/apa.html 
http://standards.freedesktop.org/menu-spec/latest/apb.html 

Also, I think use of dcop doesn't make anything useless outside KDE per se.  
It might be suboptimal and there may be other reasons for not showing 
something in eg. GNOME menus, but I think the "dcop -> KDE only" 
generalization shouldn't be made, but rather considered case by case instead. 

Right, "it uses dcop" was the quickest justification I had in mind, which was
actually wrong. I just tried yakuake in GNOME, and it works fine. It appears in
the menu too, so the right way to hide it is in fact to add --only-show-in.
Well, since it works fine in GNOME, we can leave it in the menu. No change to do
to the package then.

Package Change Request
======================
Package Name: yakuake
New Branches: EL-6
Owners: s4504kr
InitialCC: