Bug 1717188
| Summary: | Review Request: go-rpm-macros - rpm automation to simplify the creation of Go packages | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Nicolas Mailhot <nicolas.mailhot> |
| Component: | Package Review | Assignee: | Robert-André Mauchin 🐧 <eclipseo> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | decathorpe, eclipseo, jcajka, package-review, quantum.analyst |
| Target Milestone: | --- | Flags: | eclipseo:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | go-rpm-macros-3.0.8-3.fc31 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2020-02-08 21:32:31 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1714090 | ||
| Bug Blocks: | |||
|
Description
Nicolas Mailhot
2019-06-04 20:45:45 UTC
- Capitalize this summary: go-rpm-templates.noarch: W: summary-not-capitalized C rpm spec templates for Go packages - You need to add a %changelog go-rpm-templates.noarch: E: no-changelogname-tag - License ok - Latest version packaged - Builds in mock - Conforms to Packaging Guidelines Also I can't install it: DEBUG util.py:585: BUILDSTDERR: Error: DEBUG util.py:585: BUILDSTDERR: Problem 1: conflicting requests DEBUG util.py:585: BUILDSTDERR: - nothing provides go-srpm-macros = 3.0.8-2.0.fc31 needed by go-rpm-macros-3.0.8-2.0.fc31.x86_64 Scratch that might be a fedora-review issue. (In reply to Robert-André Mauchin from comment #1) Hi, > - Capitalize this summary: > > go-rpm-templates.noarch: W: summary-not-capitalized C rpm spec templates for > Go packages Do you prefer Rpm spec templates for Go packages RPM spec templates for Go packages I find them both worse and ugly, but maybe that's just my habits > > - You need to add a %changelog > > go-rpm-templates.noarch: E: no-changelogname-tag Added, sorry, it's all been much too long > - License ok > - Latest version packaged > - Builds in mock > - Conforms to Packaging Guidelines > Scratch that might be a fedora-review issue. Yes seems like it Anyway here it is https://copr-be.cloud.fedoraproject.org/results/nim/macros-ng/fedora-rawhide-x86_64/00921221-go-rpm-macros/go-rpm-macros.spec As noted many times prior to this I'm against centralization of all golang-macros packages in one single repo, i.e. go-srpm-macros should be separate package/repo so there can be more limited access as any changes to it have potential to break whole distribution's buildroot. I'll approve as is as both packages are tightly coupled. We'll need to be eytra careful in any future changes to not break the buildroot. Any changes should be tested in a minimal buildroot on COPR. Thanks for the review! I agree changes should be tested, preferably by several people. (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/go-rpm-macros Thanks for creating the repo! I don't think this is going to be backported to Fedora 30, so might as well close, as it's been imported otherwise. |