Bug 1717188 - Review Request: go-rpm-macros - rpm automation to simplify the creation of Go packages
Summary: Review Request: go-rpm-macros - rpm automation to simplify the creation of Go...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1714090
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-06-04 20:45 UTC by Nicolas Mailhot
Modified: 2020-02-08 21:32 UTC (History)
5 users (show)

Fixed In Version: go-rpm-macros-3.0.8-3.fc31
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-02-08 21:32:31 UTC
Type: ---
Embargoed:
zebob.m: fedora-review+


Attachments (Terms of Use)

Description Nicolas Mailhot 2019-06-04 20:45:45 UTC
Spec URL: https://copr-be.cloud.fedoraproject.org/results/nim/macros-ng/fedora-rawhide-x86_64/00920979-go-rpm-macros/go-rpm-macros.spec

Description: This package provides rpm automation to simplify the creation of Go
language (golang) packages.

With golist, it forms the backbone of
https://pagure.io/packaging-committee/issue/382

Fedora Account System Username: nim

Use requirements:

1. redhat-rpm-config >= 130 https://koji.fedoraproject.org/koji/buildinfo?buildID=1279072
2. golist >= 0.10.0         https://bugzilla.redhat.com/show_bug.cgi?id=1714090
3. golang with https://src.fedoraproject.org/rpms/golang/pull-request/1 to avoid directory ownership clashes

Comment 1 Robert-André Mauchin 🐧 2019-06-04 21:46:48 UTC
 - Capitalize this summary:

go-rpm-templates.noarch: W: summary-not-capitalized C rpm spec templates for Go packages

 - You need to add a %changelog

go-rpm-templates.noarch: E: no-changelogname-tag

 - License ok
 - Latest version packaged
 - Builds in mock
 - Conforms to Packaging Guidelines

Comment 2 Robert-André Mauchin 🐧 2019-06-04 21:48:43 UTC
Also I can't install it:

DEBUG util.py:585:  BUILDSTDERR: Error: 
DEBUG util.py:585:  BUILDSTDERR:  Problem 1: conflicting requests
DEBUG util.py:585:  BUILDSTDERR:   - nothing provides go-srpm-macros = 3.0.8-2.0.fc31 needed by go-rpm-macros-3.0.8-2.0.fc31.x86_64

Comment 3 Robert-André Mauchin 🐧 2019-06-04 21:51:19 UTC
Scratch that might be a fedora-review issue.

Comment 4 Nicolas Mailhot 2019-06-05 06:54:48 UTC
(In reply to Robert-André Mauchin from comment #1)

Hi,

>  - Capitalize this summary:
> 
> go-rpm-templates.noarch: W: summary-not-capitalized C rpm spec templates for
> Go packages

Do you prefer

Rpm spec templates for Go packages
RPM spec templates for Go packages

I find them both worse and ugly, but maybe that's just my habits

> 
>  - You need to add a %changelog
> 
> go-rpm-templates.noarch: E: no-changelogname-tag

Added, sorry, it's all been much too long

>  - License ok
>  - Latest version packaged
>  - Builds in mock
>  - Conforms to Packaging Guidelines

> Scratch that might be a fedora-review issue.

Yes seems like it

Anyway here it is
https://copr-be.cloud.fedoraproject.org/results/nim/macros-ng/fedora-rawhide-x86_64/00921221-go-rpm-macros/go-rpm-macros.spec

Comment 5 Jakub Čajka 2019-06-05 07:19:05 UTC
As noted many times prior to this I'm against centralization of all golang-macros packages in one single repo, i.e. go-srpm-macros should be separate package/repo so there can be more limited access as any changes to it have potential to break whole distribution's buildroot.

Comment 6 Robert-André Mauchin 🐧 2019-06-05 21:04:12 UTC
I'll approve as is as both packages are tightly coupled. We'll need to be eytra careful in any future changes to not break the buildroot. Any changes should be tested in a minimal buildroot on COPR.

Comment 7 Nicolas Mailhot 2019-06-06 06:03:01 UTC
Thanks for the review! I agree changes should be tested, preferably by several people.

Comment 8 Igor Raits 2019-06-08 09:38:18 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/go-rpm-macros

Comment 9 Nicolas Mailhot 2019-06-08 10:14:58 UTC
Thanks for creating the repo!

Comment 10 Elliott Sales de Andrade 2020-02-08 21:32:31 UTC
I don't think this is going to be backported to Fedora 30, so might as well close, as it's been imported otherwise.


Note You need to log in before you can comment on or make changes to this bug.