Spec URL: https://copr-be.cloud.fedoraproject.org/results/nim/macros-ng/fedora-rawhide-x86_64/00920979-go-rpm-macros/go-rpm-macros.spec Description: This package provides rpm automation to simplify the creation of Go language (golang) packages. With golist, it forms the backbone of https://pagure.io/packaging-committee/issue/382 Fedora Account System Username: nim Use requirements: 1. redhat-rpm-config >= 130 https://koji.fedoraproject.org/koji/buildinfo?buildID=1279072 2. golist >= 0.10.0 https://bugzilla.redhat.com/show_bug.cgi?id=1714090 3. golang with https://src.fedoraproject.org/rpms/golang/pull-request/1 to avoid directory ownership clashes
- Capitalize this summary: go-rpm-templates.noarch: W: summary-not-capitalized C rpm spec templates for Go packages - You need to add a %changelog go-rpm-templates.noarch: E: no-changelogname-tag - License ok - Latest version packaged - Builds in mock - Conforms to Packaging Guidelines
Also I can't install it: DEBUG util.py:585: BUILDSTDERR: Error: DEBUG util.py:585: BUILDSTDERR: Problem 1: conflicting requests DEBUG util.py:585: BUILDSTDERR: - nothing provides go-srpm-macros = 3.0.8-2.0.fc31 needed by go-rpm-macros-3.0.8-2.0.fc31.x86_64
Scratch that might be a fedora-review issue.
(In reply to Robert-André Mauchin from comment #1) Hi, > - Capitalize this summary: > > go-rpm-templates.noarch: W: summary-not-capitalized C rpm spec templates for > Go packages Do you prefer Rpm spec templates for Go packages RPM spec templates for Go packages I find them both worse and ugly, but maybe that's just my habits > > - You need to add a %changelog > > go-rpm-templates.noarch: E: no-changelogname-tag Added, sorry, it's all been much too long > - License ok > - Latest version packaged > - Builds in mock > - Conforms to Packaging Guidelines > Scratch that might be a fedora-review issue. Yes seems like it Anyway here it is https://copr-be.cloud.fedoraproject.org/results/nim/macros-ng/fedora-rawhide-x86_64/00921221-go-rpm-macros/go-rpm-macros.spec
As noted many times prior to this I'm against centralization of all golang-macros packages in one single repo, i.e. go-srpm-macros should be separate package/repo so there can be more limited access as any changes to it have potential to break whole distribution's buildroot.
I'll approve as is as both packages are tightly coupled. We'll need to be eytra careful in any future changes to not break the buildroot. Any changes should be tested in a minimal buildroot on COPR.
Thanks for the review! I agree changes should be tested, preferably by several people.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/go-rpm-macros
Thanks for creating the repo!
I don't think this is going to be backported to Fedora 30, so might as well close, as it's been imported otherwise.