Bug 1717754

Summary:	Enable features.locks-notify-contention by default
Product:	[Community] GlusterFS	Reporter:	Xavi Hernandez <jahernan>
Component:	locks	Assignee:	Xavi Hernandez <jahernan>
Status:	CLOSED NEXTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1720488 (view as bug list)		Environment:
Last Closed:	2019-06-26 06:05:22 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1720488

Description Xavi Hernandez 2019-06-06 06:28:32 UTC

Description of problem:

Currently 'features.locks-notify-contention' is disabled by default. This option, when enabled, instructs the locks xlator to send an upcall notification to the current owner of a lock whenever another client tries to acquire a conflicting lock.

Both AFR and EC support this notification and react by releasing the lock as soon as possible. This is extremely useful when eager-lock is enabled (it is by default) because it allows AFR and EC to use it to improve performance but we don't loose performance on other clients when access to the same resource is required.

Since eager-lock is enabled by default, it doesn't make sense to keep contention notification disabled.

Version-Release number of selected component (if applicable): mainline


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Worker Ant 2019-06-06 06:31:15 UTC

REVIEW: https://review.gluster.org/22828 (locks: enable notify-contention by default) posted (#1) for review on master by Xavi Hernandez

Comment 2 Worker Ant 2019-06-26 06:05:22 UTC

REVIEW: https://review.gluster.org/22828 (locks: enable notify-contention by default) merged (#4) on master by Pranith Kumar Karampuri