Bug 1719169
| Summary: | use a common error prefix for drive_add errors | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux Advanced Virtualization | Reporter: | Ján Tomko <jtomko> |
| Component: | qemu-kvm | Assignee: | Maxim Levitsky <mlevitsk> |
| Status: | CLOSED NOTABUG | QA Contact: | qing.wang <qinwang> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | low | ||
| Version: | 8.0 | CC: | armbru, jinzhao, juzhang, pkrempa, virt-maint |
| Target Milestone: | rc | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2020-01-27 20:47:56 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1718255 | ||
At this point libvirt already uses blockdev-add, which has error reporting by default, so there's no point in fixing the HMP version. |
Description of problem: drive_add does not use a common prefix for errors, thus making errors like: "LUKS version 2 is not supported\r\n" hard to parse Steps to Reproduce: 1. Create a LUKSv2 disk 2. Try attaching it via libvirt Actual results: drive_add returns: "LUKS version 2 is not supported\r\n" Expected results: "Error: LUKS version 2 is not supported\r\n" Additional info: There was an error prefix added upstream: commit 66363e9a43f649360a3f74d2805c9f864da027eb HMP: Prepend errors with 'Error:' but drive_add does not seem to be using hmp_handle_error as of upstream commit 185b7ccc11354cbd69b6d53bf8d831dd964f6c88