Bug 1719169 - use a common error prefix for drive_add errors
Summary: use a common error prefix for drive_add errors
Alias: None
Product: Red Hat Enterprise Linux Advanced Virtualization
Classification: Red Hat
Component: qemu-kvm
Version: 8.0
Hardware: Unspecified
OS: Unspecified
Target Milestone: rc
: ---
Assignee: Maxim Levitsky
QA Contact: qing.wang
Depends On:
Blocks: 1718255
TreeView+ depends on / blocked
Reported: 2019-06-11 08:42 UTC by Ján Tomko
Modified: 2020-01-27 20:47 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Last Closed: 2020-01-27 20:47:56 UTC
Type: Bug
Target Upstream Version:

Attachments (Terms of Use)

Description Ján Tomko 2019-06-11 08:42:31 UTC
Description of problem:
drive_add does not use a common prefix for errors, thus making errors like:
"LUKS version 2 is not supported\r\n" hard to parse

Steps to Reproduce:
1. Create a LUKSv2 disk
2. Try attaching it via libvirt

Actual results:
drive_add returns:
"LUKS version 2 is not supported\r\n"

Expected results:
"Error: LUKS version 2 is not supported\r\n"

Additional info:
There was an error prefix added upstream:
commit 66363e9a43f649360a3f74d2805c9f864da027eb
    HMP: Prepend errors with 'Error:'
but drive_add does not seem to be using hmp_handle_error
as of upstream commit 185b7ccc11354cbd69b6d53bf8d831dd964f6c88

Comment 2 Peter Krempa 2020-01-27 20:47:56 UTC
At this point libvirt already uses blockdev-add, which has error reporting by default, so there's no point in fixing the HMP version.

Note You need to log in before you can comment on or make changes to this bug.