Bug 1720640

Summary: Clicking on Customize in Requests leadst to: undefined method `[]' for nil:NilClass [miq_request/prov_field_changed]
Product: Red Hat CloudForms Management Engine Reporter: Jaroslav Henner <jhenner>
Component: UI - OPSAssignee: Brian McLaughlin <bmclaugh>
Status: CLOSED ERRATA QA Contact: Jaroslav Henner <jhenner>
Severity: medium Docs Contact: Red Hat CloudForms Documentation <cloudforms-docs>
Priority: high    
Version: 5.10.6CC: bmidwood, hkataria, jhardy, lavenel, mpovolny, mshriver, obarenbo, simaishi
Target Milestone: GAKeywords: Regression
Target Release: 5.11.0   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: 5.11.0.13 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-12-12 13:36:36 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: Bug
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: CFME Core Target Upstream Version:
Embargoed:
Bug Depends On: 1728295, 1729907    
Bug Blocks:    

Description Jaroslav Henner 2019-06-14 12:22:29 UTC 
Description of problem:
When clicking on the RHEV Provisioning Request with cusom_template an error page is displayed saying 

Error text:

undefined method `[]' for nil:NilClass [miq_request/prov_field_changed]


Version-Release number of selected component (if applicable):
Version 5.10.6.0.20190610201431_b655f24


How reproducible:
2/2

Steps to Reproduce:
1. Create a VM with provisioning request, with a customisation template (cloudinit-rhv).
2. Click on the finished request. This brings you to the page like
https://10.8.198.215/miq_request/show/4#/
3. Click on the Customize tab

Actual results:
undefined method `[]' for nil:NilClass [miq_request/prov_field_changed]

Expected results:
Customize tab displays

Additional info:
Comment 2 Jaroslav Henner 2019-06-14 12:41:21 UTC 
Happens also in 5.10.5.1, without the need for a Request to be in Finished state.
Comment 3 Jaroslav Henner 2019-06-14 12:50:26 UTC 
5.9.9.1.20190304164243_28a581b  is fine.
Comment 8 CFME Bot 2019-07-03 19:57:10 UTC 
https://github.com/ManageIQ/manageiq-ui-classic/pull/5774
Comment 9 CFME Bot 2019-07-03 20:21:48 UTC 
New commit detected on ManageIQ/manageiq-ui-classic/master:

https://github.com/ManageIQ/manageiq-ui-classic/commit/553ea4b187bea1acad64071d713e5b73f12044d8
commit 553ea4b187bea1acad64071d713e5b73f12044d8
Author:     Brian McLaughlin <bmclaugh>
AuthorDate: Wed Jul  3 15:22:29 2019 -0400
Commit:     Brian McLaughlin <bmclaugh>
CommitDate: Wed Jul  3 15:22:29 2019 -0400

    Fix error viewing Customize tab on Requests

    https://bugzilla.redhat.com/show_bug.cgi?id=1720640

 app/views/shared/views/_prov_dialog.html.haml | 9 +-
 1 file changed, 5 insertions(+), 4 deletions(-)
Comment 10 Jaroslav Henner 2019-07-25 14:09:01 UTC 
Clicking on Customize now doesn't cause such error.
Comment 12 errata-xmlrpc 2019-12-12 13:36:36 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:4199
Comment 13 Jaroslav Henner 2020-05-26 19:22:19 UTC 
I belive we covered this with the linked #1797706