Bug 1720700
| Summary: | Request to add a note merging stage to the post-link process | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Nick Clifton <nickc> | ||||
| Component: | rpm | Assignee: | Packaging Maintenance Team <packaging-team-maint> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | 31 | CC: | igor.raits, mjw, packaging-team-maint, pmatilai, pmoravco, vmukhame | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2019-08-28 11:24:08 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
Can you please send a patch to https://github.com/rpm-software-management/rpm ? (In reply to Igor Gnatenko from comment #1) > Can you please send a patch to > https://github.com/rpm-software-management/rpm ? The annobin notes are only generated in Fedora and RHEL, so I am not sure if the upstream rpm maintainers will want to add a patch just for us. Cheers Nick (In reply to Igor Gnatenko from comment #1) > Can you please send a patch to > https://github.com/rpm-software-management/rpm ? I have now created a pull-request... Hi Igor, (In reply to Igor Gnatenko from comment #1) > Can you please send a patch to > https://github.com/rpm-software-management/rpm ? The patch has now been accepted into the upstream rpm sources: commit cc1965ce3acaa7d9356b7671050a15e2cda2f424 Author: nickclifton <31441682+nickclifton.github.com> Date: Wed Jun 19 12:45:09 2019 +0100 Add step to find-debuginfo.sh script to compress annobin notes. Please could this be pulled into Fedora ? Cheers Nick Hmm, I thought I already commented on this but apparently not, sorry. This will be pulled into Fedora when we rebase to 4.15-beta, should happen this week. This bug appears to have been reported against 'rawhide' during the Fedora 31 development cycle. Changing version to 31. Added as of rpm >= 4.15.0-beta in both F31 and rawhide |
Created attachment 1580729 [details] Proposed patch to be picked up by rpm.spec Description of problem: With the introduction of the annobin gcc plugin to the build process, built binary files have become larger. Sometimes significantly so. This is a request to add a new step to the post-link process performed by rpmbuild, to run the objcopy program with the --merge-notes option specified. This will reduce the size of the annobin notes in binary files, thus alleviating the size growth. The attached patch is a suggested method for providing this feature. I have tested it locally and found that it works for a single test build, but I have not run a full scratch mass rebuild, so there may be some issues that I have not considered.