Bug 1720700 - Request to add a note merging stage to the post-link process
Summary: Request to add a note merging stage to the post-link process
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: rpm
Version: 31
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Packaging Maintenance Team
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-06-14 15:10 UTC by Nick Clifton
Modified: 2019-08-28 11:24 UTC (History)
6 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2019-08-28 11:24:08 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)
Proposed patch to be picked up by rpm.spec (510 bytes, patch)
2019-06-14 15:10 UTC, Nick Clifton 		no flags Details | Diff
View All


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 1719837 0 medium CLOSED Request to add a note merging stage to the post-link process 2023-03-26 09:08:07 UTC

Description Nick Clifton 2019-06-14 15:10:44 UTC 
Created attachment 1580729 [details]
Proposed patch to be picked up by rpm.spec

Description of problem:

  With the introduction of the annobin gcc plugin to the build process,
  built binary files have become larger.  Sometimes significantly so.
  This is a request to add a new step to the post-link process performed
  by rpmbuild, to run the objcopy program with the --merge-notes option
  specified.  This will reduce the size of the annobin notes in binary 
  files, thus alleviating the size growth.

  The attached patch is a suggested method for providing this feature.
  I have tested it locally and found that it works for a single test
  build, but I have not run a full scratch mass rebuild, so there may
  be some issues that I have not considered.
Comment 1 Igor Raits 2019-06-14 15:14:50 UTC 
Can you please send a patch to https://github.com/rpm-software-management/rpm ?
Comment 2 Nick Clifton 2019-06-14 15:39:59 UTC 
(In reply to Igor Gnatenko from comment #1)
> Can you please send a patch to
> https://github.com/rpm-software-management/rpm ?

The annobin notes are only generated in Fedora and RHEL, so I am not sure
if the upstream rpm maintainers will want to add a patch just for us.

Cheers
  Nick
Comment 3 Nick Clifton 2019-06-14 16:30:18 UTC 
(In reply to Igor Gnatenko from comment #1)
> Can you please send a patch to
> https://github.com/rpm-software-management/rpm ?

I have now created a pull-request...
Comment 4 Nick Clifton 2019-06-20 13:30:59 UTC 
Hi Igor,

(In reply to Igor Gnatenko from comment #1)
> Can you please send a patch to
> https://github.com/rpm-software-management/rpm ?

The patch has now been accepted into the upstream rpm sources:

  commit cc1965ce3acaa7d9356b7671050a15e2cda2f424
  Author: nickclifton <31441682+nickclifton.github.com>
  Date:   Wed Jun 19 12:45:09 2019 +0100

    Add step to find-debuginfo.sh script to compress annobin notes.
    
Please could this be pulled into Fedora ?

Cheers
  Nick
Comment 5 Panu Matilainen 2019-06-25 08:12:17 UTC 
Hmm, I thought I already commented on this but apparently not, sorry.

This will be pulled into Fedora when we rebase to 4.15-beta, should happen this week.
Comment 6 Ben Cotton 2019-08-13 19:09:23 UTC 
This bug appears to have been reported against 'rawhide' during the Fedora 31 development cycle.
Changing version to 31.
Comment 7 Panu Matilainen 2019-08-28 11:24:08 UTC 
Added as of rpm >= 4.15.0-beta in both F31 and rawhide
Note You need to log in before you can comment on or make changes to this bug.