Bug 1723254
| Summary: | Kebab actions for resources lists does not work for the last row | ||||||
|---|---|---|---|---|---|---|---|
| Product: | OpenShift Container Platform | Reporter: | XiaochuanWang <xiaocwan> | ||||
| Component: | Management Console | Assignee: | cvogt | ||||
| Status: | CLOSED ERRATA | QA Contact: | Yadan Pei <yapei> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | 4.2.0 | CC: | aos-bugs, bkunal, gedasilv, jokerman, mmccomas, rhamilto, spadgett, tdale, tgolembi, yapei | ||||
| Target Milestone: | --- | Keywords: | Reopened | ||||
| Target Release: | 4.3.0 | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: |
Cause:
Kebab menu always opened down and was parented to the scrollable list itself. Therefore it was subjected to being clipped by a parent DOM node with an `overflow` style.
Consequence:
The kebab menu for the last list item was often clipped and the user could not see all the items.
Fix:
The kebab menu is now parented to the document body ensuring it cannot be clipped by a scrollable parent node. It also smartly determines its position; whether to open up or down.
Result:
The kebab menu will always be visible. In some cases the kebab menu will open upwards to ensure it remains visible in its entirety.
|
Story Points: | --- | ||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2020-01-23 11:04:11 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
Xiaochuan, in trying to reproduce the bug, I am able to scroll to reveal both dropdown options. Is that not the case for you? Note this should not be a new behavior. It's possible the scrolling is worse than before due changes of all tables (see https://github.com/openshift/console/pull/1465), but Patrick has a PR in progress to address (see https://github.com/openshift/console/pull/1750). Having to scroll after opening the kebab for the last row isn't ideal, but I think it's reasonable if all the items can be clicked. Xiaochuan, can you let us know if you're able to scroll to click the last item? As Robb notes, this should be made better by https://github.com/openshift/console/pull/1750 Samuel, after clicked the Kebab button and scrolled down, I still can not get the following buttons from the Kebab list. This is different than 4.1 which will be able to get the whole buttons by rolling out extra empty lines at the bottom of the screen. It's related to Browser, reproduced on Firefox 64 and 67, not on Chrome 72. *** Bug 1726989 has been marked as a duplicate of this bug. *** This was addressed in https://github.com/openshift/console/pull/1750 This has been fixed, namespaces list and projects list does not reproduce it now. Verified on 4.2.0-0.nightly-2019-07-31-162901 The kebab action menus can't be selected when kebab list height exceed the bottom, scroll down doesn't work Reproduces on 4.2.0-0.nightly-2019-09-17-001320 In our trying, the issue reproduces on FF69 & Chrome 75 while FF68 & Chrome 77 don't have I can reproduce on Firefox 69 It appears this is a known issue with React Virtualized and React Virtualized creator, Brian Vaughn, recommends https://github.com/tajo/react-portal as the fix. See https://stackoverflow.com/a/43331841, https://stackoverflow.com/a/47334746. *** Bug 1760433 has been marked as a duplicate of this bug. *** Checked on Firefox 70 and Chrome 78, both are not reproduced. Kebab action drop-down list for the last item are now drop-UP. Tested on 4.3.0-0.nightly-2019-11-13-233341 *** Bug 1779649 has been marked as a duplicate of this bug. *** *** Bug 1782825 has been marked as a duplicate of this bug. *** Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2020:0062 *** Bug 1804287 has been marked as a duplicate of this bug. *** |
Created attachment 1583837 [details] project kebab list actions Description of problem: Cluster admin check Projects list and Namespaces list, both kebab buttons are truncated for the last project/namespace. Version-Release number of selected component (if applicable): Latest commit of Console: 3829040ef07c2a6ac8111e04b8e8f2515a089763 How reproducible: Always Steps to Reproduce: 1. Go to Projects list, check the kebab list for the last project in the bottom. 2. Go to Namespaces list, check the kebab list for the last Namespace in the bottom. Actual results: Both step 1&2, there is only "Edit Labels" button. Expected results: Both step 1&2, should display well. Additional info: