Bug 1723420

Summary:	[RFE] Reduce the number of ssh connections when verifying a conversion host
Product:	Red Hat CloudForms Management Engine	Reporter:	Daniel Berger <dberger>
Component:	V2V	Assignee:	Daniel Berger <dberger>
Status:	CLOSED ERRATA	QA Contact:	Shveta <sshveta>
Severity:	medium	Docs Contact:	Red Hat CloudForms Documentation <cloudforms-docs>
Priority:	medium
Version:	5.10.6	CC:	bthurber, fdupont, simaishi
Target Milestone:	GA	Keywords:	RFE
Target Release:	5.11.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	5.11.0.14	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-12-12 13:36:46 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	Feature
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	V2V	Target Upstream Version:
Embargoed:

Description Daniel Berger 2019-06-24 13:40:28 UTC

Internally it is possible for a conversion host instance to continually re-verify its authentication status, despite the fact that it may have just validated minutes or seconds before. This causes unnecessary ssh connections in the ConversionHost#verify_credentials method.

Instead, it should assume that as long as it successfully validated within the last X minutes, and there were no unsuccessful validations in the last X minutes, that the authentication is valid.

Comment 3 Shveta 2019-07-30 20:43:58 UTC

Talked to Daniel , This BZ cannot be verified through UI .
PR is merged .
Verifying .

Comment 4 Daniel Berger 2019-07-30 20:45:35 UTC

Just FYI, ultimately we relied on a mixin method that already existed called authentication_status_ok from the AuthenticationMixin, and check that instead of using a timer.

https://github.com/ManageIQ/manageiq/blob/master/app/models/mixins/authentication_mixin.rb#L130

Comment 6 errata-xmlrpc 2019-12-12 13:36:46 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:4199