Bug 1723420 - [RFE] Reduce the number of ssh connections when verifying a conversion host
Summary: [RFE] Reduce the number of ssh connections when verifying a conversion host
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: V2V
Version: 5.10.6
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: GA
: 5.11.0
Assignee: Daniel Berger
QA Contact: Shveta
Red Hat CloudForms Documentation
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-06-24 13:40 UTC by Daniel Berger
Modified: 2020-06-30 18:19 UTC (History)
3 users (show)

Fixed In Version: 5.11.0.14
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-12-12 13:36:46 UTC
Category: Feature
Cloudforms Team: V2V
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2019:4199 0 None None None 2019-12-12 13:36:58 UTC

Description Daniel Berger 2019-06-24 13:40:28 UTC
Internally it is possible for a conversion host instance to continually re-verify its authentication status, despite the fact that it may have just validated minutes or seconds before. This causes unnecessary ssh connections in the ConversionHost#verify_credentials method.

Instead, it should assume that as long as it successfully validated within the last X minutes, and there were no unsuccessful validations in the last X minutes, that the authentication is valid.

Comment 3 Shveta 2019-07-30 20:43:58 UTC
Talked to Daniel , This BZ cannot be verified through UI .
PR is merged .
Verifying .

Comment 4 Daniel Berger 2019-07-30 20:45:35 UTC
Just FYI, ultimately we relied on a mixin method that already existed called authentication_status_ok from the AuthenticationMixin, and check that instead of using a timer.

https://github.com/ManageIQ/manageiq/blob/master/app/models/mixins/authentication_mixin.rb#L130

Comment 6 errata-xmlrpc 2019-12-12 13:36:46 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:4199


Note You need to log in before you can comment on or make changes to this bug.