Bug 1725956

Summary: puppet-tripleo RPM is missing a dependency on puppet-etcd
Product: Red Hat OpenStack Reporter: Alan Bishop <abishop>
Component: puppet-tripleoAssignee: Alan Bishop <abishop>
Status: CLOSED ERRATA QA Contact: Tzach Shefi <tshefi>
Severity: high Docs Contact:
Priority: high    
Version: 15.0 (Stein)CC: cschwede, eharney, gcharot, jjoyce, jschluet, pgrist, slinaber, tvignaud
Target Milestone: rcKeywords: Triaged
Target Release: 15.0 (Stein)   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: puppet-tripleo-10.5.1-0.20190812120435.ed6c6b0.el8ost Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-09-21 11:23:46 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1636040, 1794654    

Description Alan Bishop 2019-07-01 20:09:04 UTC
Description of problem:

puppet-tripleo supports configuring the etcd3 service via the puppet-etcd module. However, puppet-etcd is missing from the RPM dependencies.


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. Deploy overcloud is -e environments/cinder-active-active.yaml, which triggers configuration of the etcd service.
2.
3.

Actual results:

Puppet configuration of etcd service fails:

        "2019-06-30 09:07:29,480 ERROR: 279871 -- ['/usr/bin/podman', 'run', '--user', 'root', '--name', 'container-puppet-etcd', '--env', 'PUPPET_TAGS=file,file_line,concat,augeas,cron', '--env', 'NAME=etcd', '--env', 'HOSTNAME=controller-0', '--env', 'NO_ARCHIVE=', '--env', 'STEP
=6', '--env', 'NET_HOST=true', '--log-driver', 'json-file', '--volume', '/etc/localtime:/etc/localtime:ro', '--volume', '/tmp/tmp58bmhtlv:/etc/config.pp:ro', '--volume', '/etc/puppet/:/tmp/puppet-etc/:ro', '--volume', '/etc/pki/ca-trust/extracted:/etc/pki/ca-trust/extracted:ro', '-
-volume', '/etc/pki/tls/certs/ca-bundle.crt:/etc/pki/tls/cert/var/lib/config-data/puppet-generated/etcd/s/ca-bundle.crt:ro', '--volume', '/etc/pki/tls/certs/ca-bundle.trust.crt:/etc/pki/tls/certs/ca-bundle.trust.crt:ro', '--volume', '/etc/pki/tls/cert.pem:/etc/pki/tls/cert.pem:ro', '--volume', '/var/lib/config-data:/var/lib
/config-data/:rw', '--volume', '/dev/log:/dev/log:rw', '--log-opt', 'path=/var/log/containers/stdouts/container-puppet-etcd.log', '--security-opt', 'label=disable', '--volume', '/usr/share/openstack-puppet/modules/:/usr/share/openstack-puppet/modules/:ro', '--entrypoint', '/var/lib
/container-puppet/container-puppet.sh', '--net', 'host', '--volume', '/etc/hosts:/etc/hosts:ro', '--volume', '/var/lib/container-puppet/container-puppet.sh:/var/lib/container-puppet/container-puppet.sh:ro', '192.168.24.1:8787/rhosp15/openstack-etcd:20190621.1'] run failed after + m
kdir -p /etc/puppet",
        "+ '[' -n file,file_line,concat,augeas,cron ']'",
        "+ TAGS='--tags file,file_line,concat,augeas,cron'",
        "+ origin_of_time=/var/lib/config-data/etcd.origin_of_time",
        "+ touch /var/lib/config-data/etcd.origin_of_time",
        "+ /usr/bin/puppet apply --summarize --detailed-exitcodes --color=false --modulepath=/etc/puppet/modules:/usr/share/openstack-puppet/modules --tags file,file_line,concat,augeas,cron /etc/config.pp",
        "<13>Jun 30 09:07:07 puppet-user: Warning: /etc/puppet/hiera.yaml: Use of 'hiera.yaml' version 3 is deprecated. It should be converted to version 5",
        "<13>Jun 30 09:07:26 puppet-user:    (file: /etc/puppet/hiera.yaml)",
        "<13>Jun 30 09:07:26 puppet-user: Warning: Undefined variable '::deploy_config_name'; \\n   (file & line not available)",
        "<13>Jun 30 09:07:26 puppet-user: Warning: ModuleLoader: module 'tripleo' has unresolved dependencies - it will only see those that are resolved. Use 'puppet module list --tree' to see information about modules\\n   (file & line not available)",
        "<13>Jun 30 09:07:26 puppet-user: Error: Evaluation Error: Error while evaluating a Function Call, undefined method `provide' for nil:NilClass (file: /etc/config.pp, line: 2, column: 35) on node controller-0.localdomain",
        "+ rc=1",
        "+ '[' 1 -ne 2 -a 1 -ne 0 ']'",
        "+ exit 1",
        " attempt(s): 1",
        "2019-06-30 09:07:29,480 WARNING: 279871 -- Retrying running container: etcd",

A quick look on the controller shows the puppet-etcd module is missing.

Expected results:


Additional info:

Comment 5 Tzach Shefi 2019-08-18 04:36:45 UTC
RHOS_TRUNK-15.0-RHEL-8-20190807 this didn't include the fixed-in version
Currently installed puppet-tripleo-10.5.1-0.20190801100456 < (fixed-in)puppet-tripleo-10.5.1-0.20190812120435

I'll retry a newer "latest" build and update.

Comment 6 Tzach Shefi 2019-08-18 11:12:00 UTC
Looks* to be verified on:
puppet-tripleo-10.5.1-0.20190812120435.ed6c6b0.el8ost.noarch

Cinder A/A still failed to deploy however we now have etcd rpm installed on controller

[root@controller-1 ~]# rpm -qa | grep etcd
puppet-etcd-1.12.3-0.20190729090440.7555287.el8ost.noarch

However we don't have an ectd docker

[root@controller-1 ~]# podman ps | grep etcd
Null nada.. 

Waiting for input form Alan per:
https://bugzilla.redhat.com/show_bug.cgi?id=1636040#c20

Before I verify this bz.

Comment 7 Alan Bishop 2019-08-19 19:45:52 UTC
Existing of puppet-etcd-1.12.3-0.20190729090440.7555287.el8ost.noarch on the node is sufficient to verify this issue is fixed. The fact that the etcd container isn't running is a separate issue, which I'll report in another BZ.

Comment 8 Tzach Shefi 2019-08-20 04:42:22 UTC
Verifying based on comments 6,7

Comment 13 errata-xmlrpc 2019-09-21 11:23:46 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2019:2811