Bug 1726451

Summary: CCO operator does not have a level gate
Product: OpenShift Container Platform Reporter: Justin Pierce <jupierce>
Component: Cloud Credential OperatorAssignee: Devan Goodwin <dgoodwin>
Status: CLOSED ERRATA QA Contact: Oleg Nesterov <olnester>
Severity: unspecified Docs Contact:
Priority: urgent    
Version: 4.1.zCC: lmeyer, mifiedle, olnester
Target Milestone: ---   
Target Release: 4.2.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1727943 (view as bug list) Environment:
Last Closed: 2019-10-16 06:33:03 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1727943    

Description Justin Pierce 2019-07-02 21:23:24 UTC
Description of problem:
The cco clusteroperator does not set a level gate which allows the CVO to incorrectly believe it has been upgraded even if it fails. 

Version-Release number of selected component (if applicable):
4.1.4

Steps to Reproduce:
1. oc adm release extract --to=/tmp/folder quay.io/openshift-release-dev/ocp-release:4.1.4
2. edit 0000_50_cloud-credential-operator_10_cluster-operator.yaml and notice it does not have the level gate present in, for example, 0000_50_cluster-monitoring-operator_05-clusteroperator.yaml

status:
  versions:
  - name: operator
    version: "4.1.4"


Actual results:
Without this level gate, the CVO can pass by the operator during the upgrade even if the operator fails to upgrade. 

Additional info:
Urgency at request of ccoleman. release info should include:
status:
  versions:
  - name: operator
    version: "0.0.1-snapshot"

Comment 2 Devan Goodwin 2019-07-03 17:58:10 UTC
Has merged, setting ON_QA and target release 4.2. Will clone for 4.1.z.

Comment 3 Oleg Nesterov 2019-07-08 16:35:31 UTC
Verified with "oc adm release extract --to=/tmp/folder registry.svc.ci.openshift.org/origin/release:4.2"

Result:

[cloud-user@preserve-qe-olnester-ocp-workstation folder]$ cat 0000_50_cloud-credential-operator_10_cluster-operator.yaml 
apiVersion: config.openshift.io/v1
kind: ClusterOperator
metadata:
  name: cloud-credential
status:
  versions:
  - name: operator
    version: "4.2.0-0.okd-2019-07-08-162751"

Comment 4 Luke Meyer 2019-07-15 22:16:52 UTC
I believe this fix was reverted in https://github.com/openshift/cloud-credential-operator/pull/90 -- please let me know if I misunderstood, otherwise we'll want to drop this bug from the 4.1.6 advisory.

Comment 5 Oleg Nesterov 2019-07-16 06:59:40 UTC
That still works for 4.2

apiVersion: config.openshift.io/v1
kind: ClusterOperator
metadata:
  name: cloud-credential
status:
  versions:
  - name: operator
    version: "4.2.0-0.okd-2019-07-16-062255"

Comment 6 Luke Meyer 2019-07-17 01:58:33 UTC
Sorry, I failed to notice that this is the 4.2 bug. The revert was for 4.1. Thanks for looking.

Comment 7 Devan Goodwin 2019-08-06 17:27:55 UTC
*** Bug 1737420 has been marked as a duplicate of this bug. ***

Comment 8 errata-xmlrpc 2019-10-16 06:33:03 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:2922