Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1727943

Summary:	CCO operator does not have a level gate
Product:	OpenShift Container Platform	Reporter:	Devan Goodwin <dgoodwin>
Component:	Cloud Credential Operator	Assignee:	Devan Goodwin <dgoodwin>
Status:	CLOSED WONTFIX	QA Contact:	Oleg Nesterov <olnester>
Severity:	high	Docs Contact:
Priority:	high
Version:	4.1.z	CC:	jupierce, lmeyer, mifiedle, olnester, sponnaga, wsun
Target Milestone:	---
Target Release:	4.1.z
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	4.1.6
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1726451	Environment:
Last Closed:	2019-10-22 17:20:43 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1726451
Bug Blocks:

Description Devan Goodwin 2019-07-08 15:45:24 UTC

+++ This bug was initially created as a clone of Bug #1726451 +++

Description of problem:
The cco clusteroperator does not set a level gate which allows the CVO to incorrectly believe it has been upgraded even if it fails. 

Version-Release number of selected component (if applicable):
4.1.4

Steps to Reproduce:
1. oc adm release extract --to=/tmp/folder quay.io/openshift-release-dev/ocp-release:4.1.4
2. edit 0000_50_cloud-credential-operator_10_cluster-operator.yaml and notice it does not have the level gate present in, for example, 0000_50_cluster-monitoring-operator_05-clusteroperator.yaml

status:
  versions:
  - name: operator
    version: "4.1.4"


Actual results:
Without this level gate, the CVO can pass by the operator during the upgrade even if the operator fails to upgrade. 

Additional info:
Urgency at request of ccoleman. release info should include:
status:
  versions:
  - name: operator
    version: "0.0.1-snapshot"

--- Additional comment from Devan Goodwin on 2019-07-03 14:58:30 UTC ---

https://github.com/openshift/cloud-credential-operator/pull/81

--- Additional comment from Devan Goodwin on 2019-07-03 17:58:10 UTC ---

Has merged, setting ON_QA and target release 4.2. Will clone for 4.1.z.

Comment 2 Oleg Nesterov 2019-07-10 06:52:46 UTC

This bug is fixed.

[cloud-user@preserve-qe-olnester-ocp-workstation folder]$ cat 0000_50_cloud-credential-operator_10_cluster-operator.yaml
apiVersion: config.openshift.io/v1
kind: ClusterOperator
metadata:
  name: cloud-credential
status:
  versions:
  - name: operator
    version: "4.1.0-0.nightly-2019-07-09-205457"

Comment 3 Luke Meyer 2019-07-17 01:59:16 UTC

This fix was reverted in https://github.com/openshift/cloud-credential-operator/pull/90 so will not be in 4.1.6

Comment 5 Devan Goodwin 2019-08-02 17:14:28 UTC

*** Bug 1715612 has been marked as a duplicate of this bug. ***

Comment 7 Devan Goodwin 2019-10-22 17:20:43 UTC

This does not appear to be a priority and the fix is automatically deploying with 4.2. Going to close and cancel attempts to backport at this time.