Bug 1726656

It's pretty easy to hide the option in gnome-tweaks, but:
a) what if someone has it changed and would like to revert his/her decision? Where they will find it, especially when they know where it was when they've changed it the last time?
b) the gnome-software argument is kind of void for me, because 1) it's a problem of gnome-software, not of the gnome-tweaks, nor of the option itself; 2) the current state of the half-rebased desktop causes similar problems (the gnome-software-3.32.3-1 in Fedora 30 has this done better, the mentioned Repositories is always accessible, regardless whether the application menu is on or off);
c) the gnome-tweaks-3.32.0 still has the option, I would not diverge from the upstream version in this way, that may lead to confusion only, thus be counter-productive.

I'm not Nack-ing this yet, I'm open for discussion.

Maybe we can propose rebasing gnome-software anf gnome-tweaks in 8.2.

(In reply to Milan Crha from comment #1)
> It's pretty easy to hide the option in gnome-tweaks, but:
> a) what if someone has it changed and would like to revert his/her decision?
> Where they will find it, especially when they know where it was when they've
> changed it the last time?

Not sure if I follow, the option is not reverting the menu to the top panel,
so even if someone wanted to move the menu back all he can see is:
a menu item with the name of the application
a menu item Show Details which opens gnome-software page of the application
a Quit menu item

So user is basically restricting himself from all other menu options,
I'll attach the screenshot for more, I just thing it might be confusing.

> b) the gnome-software argument is kind of void for me, because 1) it's a
> problem of gnome-software, not of the gnome-tweaks, nor of the option
> itself;

It's problem of all apps that have app menus including Tweaks, disabling it 
hiding two menu items in tweaks:
Reset To Defaults
Disable ALL Shell Extensions

In baobab:
Help
About

So I am not throwing the blame on tweaks but unfortunately the option can be disabled there.

 2) the current state of the half-rebased desktop causes similar
> problems (the gnome-software-3.32.3-1 in Fedora 30 has this done better, the
> mentioned Repositories is always accessible, regardless whether the
> application menu is on or off);

Agree, but currently I am not seeing other solution than Comment 2.

> c) the gnome-tweaks-3.32.0 still has the option, I would not diverge from
> the upstream version in this way, that may lead to confusion only, thus be
> counter-productive.

Agree, what I was thinking was hiding/disabling the option but that might lead to more
bug reports. So, if we decide to leave it like this we should make sure that's documented.
A point here is that if someone will play with his tweaks not realizing what is the 
effect of the option is and restricting yourself from those options.

> I'm not Nack-ing this yet, I'm open for discussion.

I don't know either what the best solution here would be, as you pointed out diverging from
the upstream is not good. I'll go maybe back for disabling the option, what do you think ?

Regarding the upstream, how it's working there ? is it moving all menu items to the top ?

Created attachment 1587321 [details]
Menu item are gone

Btw looks like upstream has problem with this as well https://gitlab.gnome.org/GNOME/gnome-tweaks/issues/204

To clarify this request, we believe the option is obsoleted by gnome-shell 3.32 where the "application menu" in top bar is gone and moving the contents to a primary menu located within the application window. 

As confirmed by Florian in the upstream Issue, "the gross hack from the Tweaks option no longer works, so the UI should be dropped."

Also as Martin mentioned if you enable the option in Tweaks with gnome-shell 3.32 you can loose access to application menu all-together, which we see as potential risk to users.

Therefor we would like to hide the option from Tweaks as it no longer brings any benefit, as the menu is already within the window anyway and can cause potential confusion.

Okay, I'd ask Allen Day, the GNOME designer, or something like that, because I'm rather confused with all those app menu, hamburger menu, whatever menu terminology, but if the upstream says drop it, then let's drop it.

Thanks for the quick fix Milan,

Option is now gone
gnome-tweaks-3.28.1-6.el8.noarch

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2019:3553