Bug 1728378

Summary:	Review Request: rust-fedora-coreos-pinger - Telemetry service for Fedora CoreOS
Product:	[Fedora] Fedora	Reporter:	Robert Fairley <rfairley>
Component:	Package Review	Assignee:	Robert-André Mauchin 🐧 <zebob.m>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	bgilbert, igor.raits, package-review, rfairley, zebob.m
Target Milestone:	---	Flags:	zebob.m: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-07-28 11:26:04 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Robert Fairley 2019-07-09 19:57:30 UTC

Spec URL: https://rfairley.fedorapeople.org/package-review/rust-fedora-coreos-pinger/rust-fedora-coreos-pinger.spec
SRPM URL: https://rfairley.fedorapeople.org/package-review/rust-fedora-coreos-pinger/rust-fedora-coreos-pinger-0.0.4-1.fc31.src.rpm
Description: Telemetry service for Fedora CoreOS.
Fedora Account System Username: rfairley

Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=36155259

This can be tested after installing the package, by:

1. `systemctl start fedora-coreos-pinger.service`
2. `journalctl -u fedora-coreos-pinger.service`
3. Observe journal output. With the default config file (contained in this package) messages `Reporting enabled.` and `Collection set at level 'minimal'.` will show.

See the README: (https://github.com/coreos/fedora-coreos-pinger#configuration) for details on the configuration format.

Note this service is only a stub which parses a config file; support for transmitting the actual data will be implemented in the future. The actual data to be transmitted at each metrics collection level are under discussion at https://github.com/coreos/fedora-coreos-tracker/issues/86.

Comment 1 Robert Fairley 2019-07-10 06:10:24 UTC

In the specfile, the `0.0.3-1` entry in the changelog should be `0.0.4-1`. Will update the specfile and SRPM with the fix.

Comment 2 Robert Fairley 2019-07-10 14:06:29 UTC

Updated specfile to fix changelog entry.

Updated Spec URL: https://rfairley.fedorapeople.org/package-review/rust-fedora-coreos-pinger-01/rust-fedora-coreos-pinger.spec
Updated SRPM URL: https://rfairley.fedorapeople.org/package-review/rust-fedora-coreos-pinger-01/rust-fedora-coreos-pinger-0.0.4-1.fc31.src.rpm

Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=36167968

Comment 3 Robert-André Mauchin 🐧 2019-07-13 19:35:18 UTC

 - You also need to include the systemD scriptlets for your unit fale. See https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_systemd

BuildRequires: systemd-rpm-macros

[…]

%post
%systemd_post fedora-coreos-pinger.service

%preun
%systemd_preun fedora-coreos-pinger.service

%postun
%systemd_postun_with_restart fedora-coreos-pinger.service


 - License ok
 - Latest version packaged
 - Builds in mock
 - No rpmlint errors

Comment 4 Robert Fairley 2019-07-15 22:52:30 UTC

Thanks, missed that (again). Will remember next time. Added the post, preun, postun scriptlets.

Updated Spec URL: https://rfairley.fedorapeople.org/package-review/rust-fedora-coreos-pinger-02/rust-fedora-coreos-pinger.spec
Updated SRPM URL: https://rfairley.fedorapeople.org/package-review/rust-fedora-coreos-pinger-02/rust-fedora-coreos-pinger-0.0.4-1.fc31.src.rpm

Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=36280041

Comment 5 Robert-André Mauchin 🐧 2019-07-16 17:08:44 UTC

Package approved.

Comment 6 Mohan Boddu 2019-07-18 20:48:10 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-fedora-coreos-pinger