Spec URL: https://rfairley.fedorapeople.org/package-review/rust-fedora-coreos-pinger/rust-fedora-coreos-pinger.spec SRPM URL: https://rfairley.fedorapeople.org/package-review/rust-fedora-coreos-pinger/rust-fedora-coreos-pinger-0.0.4-1.fc31.src.rpm Description: Telemetry service for Fedora CoreOS. Fedora Account System Username: rfairley Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=36155259 This can be tested after installing the package, by: 1. `systemctl start fedora-coreos-pinger.service` 2. `journalctl -u fedora-coreos-pinger.service` 3. Observe journal output. With the default config file (contained in this package) messages `Reporting enabled.` and `Collection set at level 'minimal'.` will show. See the README: (https://github.com/coreos/fedora-coreos-pinger#configuration) for details on the configuration format. Note this service is only a stub which parses a config file; support for transmitting the actual data will be implemented in the future. The actual data to be transmitted at each metrics collection level are under discussion at https://github.com/coreos/fedora-coreos-tracker/issues/86.
In the specfile, the `0.0.3-1` entry in the changelog should be `0.0.4-1`. Will update the specfile and SRPM with the fix.
Updated specfile to fix changelog entry. Updated Spec URL: https://rfairley.fedorapeople.org/package-review/rust-fedora-coreos-pinger-01/rust-fedora-coreos-pinger.spec Updated SRPM URL: https://rfairley.fedorapeople.org/package-review/rust-fedora-coreos-pinger-01/rust-fedora-coreos-pinger-0.0.4-1.fc31.src.rpm Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=36167968
- You also need to include the systemD scriptlets for your unit fale. See https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_systemd BuildRequires: systemd-rpm-macros […] %post %systemd_post fedora-coreos-pinger.service %preun %systemd_preun fedora-coreos-pinger.service %postun %systemd_postun_with_restart fedora-coreos-pinger.service - License ok - Latest version packaged - Builds in mock - No rpmlint errors
Thanks, missed that (again). Will remember next time. Added the post, preun, postun scriptlets. Updated Spec URL: https://rfairley.fedorapeople.org/package-review/rust-fedora-coreos-pinger-02/rust-fedora-coreos-pinger.spec Updated SRPM URL: https://rfairley.fedorapeople.org/package-review/rust-fedora-coreos-pinger-02/rust-fedora-coreos-pinger-0.0.4-1.fc31.src.rpm Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=36280041
Package approved.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-fedora-coreos-pinger